Bug 1525938 - %check RPM macro used in %changelog needs to be escaped
Summary: %check RPM macro used in %changelog needs to be escaped
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: acpica-tools
Version: 27
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
Assignee: Al Stone (Old account - use ahs3@redhat.com)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-12-14 13:25 UTC by Kamil Dudka
Modified: 2018-01-18 21:30 UTC (History)
2 users (show)

Fixed In Version: acpica-tools-20180105-1.fc26 acpica-tools-20180105-1.fc27
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-01-18 21:11:04 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Kamil Dudka 2017-12-14 13:25:30 UTC
Description of problem:
The following change log entry contains unescaped RPM macro, which is not allowed:
* Fri Aug 18 2017 Al Stone <ahs3> - 20170728-3
- Completed the big-endian fixes (I think)
- Fix ppc64le.patch that inadvertently broke s390x
- Minor patch refresh
- Re-enable full %check for s390x


Version-Release number of selected component (if applicable):
acpica-tools-20171110-1.fc27


How reproducible:
Easily.


Steps to Reproduce:
1. rpmlint acpica-tools.spec


Actual results:
acpica-tools.spec:212: W: macro-in-%changelog %check
acpica-tools.spec:395: W: macro-in-%changelog %__global_ldflags
acpica-tools.spec:28: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 28)


Additional info:
This causes problems to csmock (a tool for fully automatic static analysis of RPM packages).

Please consider applying the following trivial patch:
--- a/acpica-tools.spec
+++ b/acpica-tools.spec
@@ -209,7 +209,7 @@ fi
 - Completed the big-endian fixes (I think)
 - Fix ppc64le.patch that inadvertently broke s390x
 - Minor patch refresh
-- Re-enable full %check for s390x
+- Re-enable full %%check for s390x

 * Mon Aug 14 2017 Al Stone <ahs3> - 20170728-2
 - Start some long delayed clean-up
@@ -392,7 +392,7 @@ fi
 - Refresh patches
 - Add patch to ensure ASLTS always reports when an error occurs, instead
   of glossing over it.
-- Add use of %__global_ldflags.  Closes BZ#1126134.
+- Add use of %%__global_ldflags.  Closes BZ#1126134.

 * Fri Aug 29 2014 Al Stone <ahs3> - 20140828-1
 - Update to latest upstream.  Closes BZ#1135352.

Comment 1 Fedora Update System 2018-01-10 21:50:22 UTC
acpica-tools-20180105-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-1db1c5f9f2

Comment 2 Fedora Update System 2018-01-10 21:50:36 UTC
acpica-tools-20180105-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2018-298b10875a

Comment 3 Fedora Update System 2018-01-11 23:08:36 UTC
acpica-tools-20180105-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-1db1c5f9f2

Comment 4 Fedora Update System 2018-01-11 23:42:25 UTC
acpica-tools-20180105-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-298b10875a

Comment 5 Fedora Update System 2018-01-18 21:11:04 UTC
acpica-tools-20180105-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.

Comment 6 Fedora Update System 2018-01-18 21:30:47 UTC
acpica-tools-20180105-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.