Bug 1526071

Summary: Review Request: nodejs-call-delayed - Like setTimeout, but with arguments reversed
Product: [Fedora] Fedora Reporter: Jared Smith <jsmith.fedora>
Component: Package ReviewAssignee: Robert-André Mauchin 🐧 <eclipseo>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: eclipseo, package-review
Target Milestone: ---Flags: eclipseo: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-12-15 16:27:22 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 956806, 1387531    

Description Jared Smith 2017-12-14 17:56:36 UTC
Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-call-delayed/nodejs-call-delayed.spec
SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-call-delayed/nodejs-call-delayed-1.0.0-1.fc28.src.rpm 
Description: Like setTimeout, but with arguments reversed
Fedora Account System Username: jsmith

Comment 1 Robert-André Mauchin 🐧 2017-12-14 19:10:51 UTC
+ /usr/bin/mocha -R spec
module.js:538
    throw err;
    ^
Error: Cannot find module 'coffee-script/register'

→ You need one more BR for the tests:

BuildRequires:	npm(coffee-script)


With that:
 - license is ok
 - package builds in mock
 - latest version is packaged
 - tests are successful
 - no rpmlint issues

Comment 3 Robert-André Mauchin 🐧 2017-12-14 20:15:31 UTC
Package approved.

Comment 4 Jared Smith 2017-12-15 15:28:20 UTC
Requested package in ticket https://pagure.io/releng/fedora-scm-requests/issue/3558

Comment 5 Gwyn Ciesla 2017-12-15 15:43:24 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/nodejs-call-delayed

Comment 6 Jared Smith 2017-12-15 16:27:22 UTC
In rawhide, closing bug