Bug 1526071 - Review Request: nodejs-call-delayed - Like setTimeout, but with arguments reversed
Summary: Review Request: nodejs-call-delayed - Like setTimeout, but with arguments rev...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: nodejs-reviews Node-RED
TreeView+ depends on / blocked
 
Reported: 2017-12-14 17:56 UTC by Jared Smith
Modified: 2017-12-15 16:27 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2017-12-15 16:27:22 UTC
Type: ---
Embargoed:
eclipseo: fedora-review+

Attachments (Terms of Use)

Description Jared Smith 2017-12-14 17:56:36 UTC 
Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-call-delayed/nodejs-call-delayed.spec
SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-call-delayed/nodejs-call-delayed-1.0.0-1.fc28.src.rpm 
Description: Like setTimeout, but with arguments reversed
Fedora Account System Username: jsmith
Comment 1 Robert-André Mauchin 🐧 2017-12-14 19:10:51 UTC 
+ /usr/bin/mocha -R spec
module.js:538
    throw err;
    ^
Error: Cannot find module 'coffee-script/register'

→ You need one more BR for the tests:

BuildRequires:	npm(coffee-script)


With that:
 - license is ok
 - package builds in mock
 - latest version is packaged
 - tests are successful
 - no rpmlint issues
Comment 2 Jared Smith 2017-12-14 20:01:09 UTC 
Sorry about that -- please try these versions instead.

Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-call-delayed/nodejs-call-delayed.spec
SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-call-delayed/nodejs-call-delayed-1.0.0-2.fc28.src.rpm
Comment 3 Robert-André Mauchin 🐧 2017-12-14 20:15:31 UTC 
Package approved.
Comment 4 Jared Smith 2017-12-15 15:28:20 UTC 
Requested package in ticket https://pagure.io/releng/fedora-scm-requests/issue/3558
Comment 5 Gwyn Ciesla 2017-12-15 15:43:24 UTC 
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/nodejs-call-delayed
Comment 6 Jared Smith 2017-12-15 16:27:22 UTC 
In rawhide, closing bug
Note You need to log in before you can comment on or make changes to this bug.