Bug 1526170

Summary:	Review Request: perl-Cpanel-JSON-XS - CPanel fork of JSON::XS, fast and correct serializing
Product:	[Fedora] Fedora	Reporter:	Emmanuel Seyman <emmanuel>
Component:	Package Review	Assignee:	Jitka Plesnikova <jplesnik>
Status:	CLOSED DUPLICATE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jplesnik, package-review
Target Milestone:	---	Flags:	jplesnik: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-12-20 17:14:27 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Emmanuel Seyman 2017-12-14 21:11:56 UTC

Spec URL: http://people.parinux.org/~seyman/fedora/perl-Cpanel-JSON-XS/perl-Cpanel-JSON-XS.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Cpanel-JSON-XS/perl-Cpanel-JSON-XS-3.0239-1.fc27.src.rpm
Description:
This module converts Perl data structures to JSON and vice versa. Its
primary goal is to be correct and its secondary goal is to be fast. To
reach the latter goal it was written in C.

Fedora Account System Username: eseyman
Rpmlint Output: 
perl-Cpanel-JSON-XS.src: W: spelling-error %description -l en_US versa -> avers, verse, verso
1 packages and 1 specfiles checked; 0 errors, 1 warnings.

Comment 1 Jitka Plesnikova 2017-12-18 09:49:30 UTC

Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

$ rpm -qp --requires perl-Cpanel-JSON-XS-3.0239-1.fc28.x86_64.rpm | sort | uniq -c
      1 libc.so.6()(64bit)
      1 libc.so.6(GLIBC_2.14)(64bit)
      1 libc.so.6(GLIBC_2.2.5)(64bit)
      1 libc.so.6(GLIBC_2.3.4)(64bit)
      1 libc.so.6(GLIBC_2.4)(64bit)
      1 libperl.so.5.26()(64bit)
      1 perl(Cpanel::JSON::XS)
      1 perl(Exporter)
      1 perl(:MODULE_COMPAT_5.26.1)
      1 perl(overload)
      1 perl(XSLoader)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
      1 rtld(GNU_HASH)
FIX: Please add following run-requires:
  - perl(Carp) - XS.pm:204

$ rpm -qp --requires perl-Cpanel-JSON-XS-bin-3.0239-1.fc28.x86_64.rpm | sort | uniq -c
      1 perl(Cpanel::JSON::XS)
      1 perl(Encode)
      1 perl(Getopt::Long)
      1 perl(Storable)
      1 perl(strict)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
      1 /usr/bin/perl
FIX: To be able converted all format mention in man pages, you should
  listed these dependencies in run-requires or at least mention them 
  as weak dependencies:
  - perl(CBOR::XS)
  - perl(Convert::Bencode)
  - perl(Compress::LZF)
  - perl(CPAN::Meta::YAML)
  - perl(Data::Dump)
  - perl(Data::Dumper)
  - perl(YAML)
  - perl(YAML::Syck)
  - perl(YAML::XS)

$ rpm -qp --provides perl-Cpanel-JSON-XS-3.0239-1.fc28.x86_64.rpm | sort | uniq -c
      1 perl(Cpanel::JSON::XS) = 3.0239
      1 perl-Cpanel-JSON-XS = 3.0239-1.fc28
      1 perl-Cpanel-JSON-XS(x86-64) = 3.0239-1.fc28
Binary provides are Ok.

$ rpm -qp --provides perl-Cpanel-JSON-XS-bin-3.0239-1.fc28.x86_64.rpm | sort | uniq -c
      1 perl-Cpanel-JSON-XS-bin = 3.0239-1.fc28
      1 perl-Cpanel-JSON-XS-bin(x86-64) = 3.0239-1.fc28
Binary provides are Ok.

$ rpmlint ./perl-Cpanel-JSON-XS*
perl-Cpanel-JSON-XS.src: W: spelling-error %description -l en_US versa -> avers, verse, verso
perl-Cpanel-JSON-XS.x86_64: W: spelling-error %description -l en_US versa -> avers, verse, verso
3 packages and 1 specfiles checked; 0 errors, 2 warnings.
Rpmlint is ok

BuildRequires
FIX: Please add following build-requires:
  - perl(Carp) - XS.pm:204
  - perl(Exporter) - XS.pm:224
  - perl(overload) - XS.pm:2210
  - perl(Data::Dumper) - t/22_comment_at_eof.t:10
  - perl(Encode) - t/20_faihu.t
  - perl(strict) - most of the tests
FIX: Please add perl-devel and gcc, because it is XS package.

TODO: Please replace PERL_INSTALL_ROOT with more common DESTDIR.

Please correct all 'FIX' issues and consider fixing 'TODO' item and
provide new spec file.

The package not approved.

Comment 2 Emmanuel Seyman 2017-12-18 10:29:03 UTC

Done.

Spec URL: http://people.parinux.org/~seyman/fedora/perl-Cpanel-JSON-XS/perl-Cpanel-JSON-XS.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Cpanel-JSON-XS/perl-Cpanel-JSON-XS-3.0239-2.fc27.src.rpm

Comment 3 Jitka Plesnikova 2017-12-18 12:09:11 UTC

> $ rpm -qp --requires perl-Cpanel-JSON-XS-3.0239-1.fc28.x86_64.rpm | sort |
> uniq -c
>       1 libc.so.6()(64bit)
>       1 libc.so.6(GLIBC_2.14)(64bit)
>       1 libc.so.6(GLIBC_2.2.5)(64bit)
>       1 libc.so.6(GLIBC_2.3.4)(64bit)
>       1 libc.so.6(GLIBC_2.4)(64bit)
>       1 libperl.so.5.26()(64bit)
>       1 perl(Cpanel::JSON::XS)
>       1 perl(Exporter)
>       1 perl(:MODULE_COMPAT_5.26.1)
>       1 perl(overload)
>       1 perl(XSLoader)
>       1 rpmlib(CompressedFileNames) <= 3.0.4-1
>       1 rpmlib(FileDigests) <= 4.6.0-1
>       1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
>       1 rpmlib(PayloadIsXz) <= 5.2-1
>       1 rtld(GNU_HASH)
> FIX: Please add following run-requires:
>   - perl(Carp) - XS.pm:204
Ok.

> $ rpm -qp --requires perl-Cpanel-JSON-XS-bin-3.0239-1.fc28.x86_64.rpm | sort
> | uniq -c
>       1 perl(Cpanel::JSON::XS)
>       1 perl(Encode)
>       1 perl(Getopt::Long)
>       1 perl(Storable)
>       1 perl(strict)
>       1 rpmlib(CompressedFileNames) <= 3.0.4-1
>       1 rpmlib(FileDigests) <= 4.6.0-1
>       1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
>       1 rpmlib(PayloadIsXz) <= 5.2-1
>       1 /usr/bin/perl
> FIX: To be able converted all format mention in man pages, you should
>   listed these dependencies in run-requires or at least mention them 
>   as weak dependencies:
>   - perl(CBOR::XS)
>   - perl(Convert::Bencode)
>   - perl(Compress::LZF)
>   - perl(CPAN::Meta::YAML)
>   - perl(Data::Dump)
>   - perl(Data::Dumper)
>   - perl(YAML)
>   - perl(YAML::Syck)
>   - perl(YAML::XS)
FIX: The dependencies should be added to list of Requires or Recommends for package perl-Cpanel-JSON-XS-bin, not to build-requires. 

> BuildRequires
> FIX: Please add following build-requires:
>   - perl(Carp) - XS.pm:204
>   - perl(Exporter) - XS.pm:224
>   - perl(overload) - XS.pm:2210
>   - perl(Data::Dumper) - t/22_comment_at_eof.t:10
>   - perl(Encode) - t/20_faihu.t
>   - perl(strict) - most of the tests
> FIX: Please add perl-devel and gcc, because it is XS package.
Ok.

> TODO: Please replace PERL_INSTALL_ROOT with more common DESTDIR.
Ok.
 
Please correct 'FIX' issue.

Comment 4 Emmanuel Seyman 2017-12-20 06:54:46 UTC

(In reply to Jitka Plesnikova from comment #3)
>
> FIX: The dependencies should be added to list of Requires or Recommends for
> package perl-Cpanel-JSON-XS-bin, not to build-requires. 

Doh!

Spec URL: http://people.parinux.org/~seyman/fedora/perl-Cpanel-JSON-XS/perl-Cpanel-JSON-XS.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Cpanel-JSON-XS/perl-Cpanel-JSON-XS-3.0239-3.fc27.src.rpm

Comment 5 Jitka Plesnikova 2017-12-20 08:43:28 UTC

The package looks good.

Approved

Comment 6 Emmanuel Seyman 2017-12-20 17:14:27 UTC

Sorry, Jitka. I'm afraid this was all for nothing.

*** This bug has been marked as a duplicate of bug 1085975 ***