Bug 1085975 - Review Request: perl-Cpanel-JSON-XS - JSON::XS for Cpanel, fast and correct serializing, also for 5.6.2
Summary: Review Request: perl-Cpanel-JSON-XS - JSON::XS for Cpanel, fast and correct s...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: David Dick
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 1526170 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-04-09 19:00 UTC by Paul Howarth
Modified: 2017-12-20 17:14 UTC (History)
3 users (show)

Fixed In Version: perl-Cpanel-JSON-XS-2.3404-2.fc21
Clone Of:
Environment:
Last Closed: 2014-04-26 20:53:41 UTC
Type: ---
Embargoed:
ddick: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)
Proposed removal of lzf compression option from command line (1.61 KB, patch)
2014-04-10 08:09 UTC, David Dick
no flags Details | Diff

Description Paul Howarth 2014-04-09 19:00:33 UTC
Spec URL: http://subversion.city-fan.org/repos/cfo-repo/perl-Cpanel-JSON-XS/branches/fedora/perl-Cpanel-JSON-XS.spec
SRPM URL: http://www.city-fan.org/~paul/extras/perl-Cpanel-JSON-XS/perl-Cpanel-JSON-XS-2.3404-1.fc21.src.rpm

Description:
This module converts Perl data structures to JSON and vice versa. Its
primary goal is to be correct and its secondary goal is to be fast. To
reach the latter goal it was written in C.

Fedora Account System Username: pghmcfc

Comment 1 David Dick 2014-04-10 08:07:29 UTC
FIX:

BR perl(Carp) # line 134 of XS.pm
BR perl(Hash::Util) # line 13 of t/12_blessed.t

Req perl(Carp) # line 134 of XS.pm
Req perl(Data::Dump) # line 212 of bin/cpanel_json_xs
Req perl(YAML) # line 180 of bin/cpanel_json_xs
Req perl(Compress::LZF) # line 179 of bin/cpanel_json_xs
Req perl(Convert::Bencode) # line 178 of bin/cpanel_json_xs

Given that
  1) i'm trying to package Compress::LZF at https://bugzilla.redhat.com/show_bug.cgi?id=1074129
  2) i'm stalled b/c of missing files in liblzf at https://bugzilla.redhat.com/show_bug.cgi?id=1075911
  3) Compress::LZF is an optional argument in a "test" command line client that will handle itself correctly if the "lzf" option is removed
i don't mind if you resubmit with a patch to just remove the lzf option.  Example patch attached.  Or block on #1074129 and wait with me :)

TODO:

Maybe remove ", also for 5.6.2" from the summary? perl 5.6.2 was a while ago.

Comment 2 David Dick 2014-04-10 08:09:04 UTC
Created attachment 884806 [details]
Proposed removal of lzf compression option from command line

Comment 3 Paul Howarth 2014-04-10 10:34:30 UTC
All issues addressed in -2:

Spec URL: http://subversion.city-fan.org/repos/cfo-repo/perl-Cpanel-JSON-XS/branches/fedora/perl-Cpanel-JSON-XS.spec
SRPM URL: http://www.city-fan.org/~paul/extras/perl-Cpanel-JSON-XS/perl-Cpanel-JSON-XS-2.3404-2.fc21.src.rpm

When you eventually get Compress::LZF approved, do you plan to do EL-6/7 branches? If not, I would like to take them.

Comment 4 David Dick 2014-04-10 10:59:48 UTC
My plan is to do EL6 and EL7.

Comment 5 David Dick 2014-04-10 11:14:23 UTC
I've checked the git logs for liblzf and Steve Traylen (owner of liblzf) has only added lzfP.h to the package.  Therefore, i have to strip out all the _best functionality of Compress::LZF as noted in that bug.  I'm doing that at the moment and hope to have the Compress::LZF ready for re-submission soon.

Comment 6 David Dick 2014-04-10 11:43:10 UTC
At any rate, package APPROVED.  I'll let you know when Compress::LZF is ready.

Comment 7 Paul Howarth 2014-04-10 12:19:17 UTC
New Package SCM Request
=======================
Package Name: perl-Cpanel-JSON-XS
Short Description: JSON::XS for Cpanel, fast and correct serializing
Owners: pghmcfc
Branches: f19 f20 el6 epel7
InitialCC: perl-sig

Thanks for the review David,

Comment 8 Gwyn Ciesla 2014-04-10 13:37:21 UTC
Git done (by process-git-requests).

Comment 9 Fedora Update System 2014-04-10 15:37:14 UTC
perl-Cpanel-JSON-XS-2.3404-2.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/perl-Cpanel-JSON-XS-2.3404-2.el6

Comment 10 Fedora Update System 2014-04-10 15:37:21 UTC
perl-Cpanel-JSON-XS-2.3404-2.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/perl-Cpanel-JSON-XS-2.3404-2.fc19

Comment 11 Fedora Update System 2014-04-10 15:37:32 UTC
perl-Cpanel-JSON-XS-2.3404-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/perl-Cpanel-JSON-XS-2.3404-2.fc20

Comment 12 Fedora Update System 2014-04-24 07:39:15 UTC
perl-Cpanel-JSON-XS-2.3404-2.fc20 has been pushed to the Fedora 20 stable repository.

Comment 13 Fedora Update System 2014-04-24 07:39:46 UTC
perl-Cpanel-JSON-XS-2.3404-2.fc19 has been pushed to the Fedora 19 stable repository.

Comment 14 Fedora Update System 2014-04-26 20:12:23 UTC
perl-Cpanel-JSON-XS-2.3404-2.el6 has been pushed to the Fedora EPEL 6 stable repository.

Comment 15 Emmanuel Seyman 2017-12-20 17:14:27 UTC
*** Bug 1526170 has been marked as a duplicate of this bug. ***


Note You need to log in before you can comment on or make changes to this bug.