Bug 1527850
| Summary: | snappy-stubs-public.h defines version macros incorrectly | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Sergey Avseyev <sergey.avseyev> |
| Component: | snappy | Assignee: | Martin Gieseking <martin.gieseking> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | martin.gieseking |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | snappy-1.1.7-2.fc28 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-12-20 10:13:00 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
Thanks for the report. Fixed in snappy-1.1.7-2.fc28. Thanks, Martin. Will you notify upstream? This issue seems like still not fixed in master branch. Reported to upstream as https://github.com/google/snappy/pull/61 Sorry, changing resolution back (scrolled on the select control by mistake) Thanks for notifying upstream. I was just about to do so too. :-) |
It seems like the snappy-devel (1.1.7) package in rawhide has been built incorrectly as it defines version macros incorrectly to be #define SNAPPY_MAJOR #define SNAPPY_MINOR #define SNAPPY_PATCHLEVEL #define SNAPPY_VERSION \ ((SNAPPY_MAJOR << 16) | (SNAPPY_MINOR << 8) | SNAPPY_PATCHLEVEL) Which leads to build errors of packages, which depend on it. How reproducible: Always Steps to Reproduce: 1. dnf install snappy-devel 2. grep "#define SNAPPY_" /usr/include/snappy-stubs-public.h Actual results: #define SNAPPY_MAJOR #define SNAPPY_MINOR #define SNAPPY_PATCHLEVEL #define SNAPPY_VERSION \ Expected results: #define SNAPPY_MAJOR 1 #define SNAPPY_MINOR 1 #define SNAPPY_PATCHLEVEL 7 #define SNAPPY_VERSION \ Additional info: Works as expected on Fedora 27