Bug 1527850 - snappy-stubs-public.h defines version macros incorrectly
Summary: snappy-stubs-public.h defines version macros incorrectly
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: snappy
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Martin Gieseking
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-12-20 09:09 UTC by Sergey Avseyev
Modified: 2017-12-20 10:50 UTC (History)
1 user (show)

Fixed In Version: snappy-1.1.7-2.fc28
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-12-20 10:13:00 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Sergey Avseyev 2017-12-20 09:09:04 UTC
It seems like the snappy-devel (1.1.7) package in rawhide has been built incorrectly as it defines version macros incorrectly to be

#define SNAPPY_MAJOR 
#define SNAPPY_MINOR 
#define SNAPPY_PATCHLEVEL 
#define SNAPPY_VERSION \
    ((SNAPPY_MAJOR << 16) | (SNAPPY_MINOR << 8) | SNAPPY_PATCHLEVEL)


Which leads to build errors of packages, which depend on it.

How reproducible: Always

Steps to Reproduce:
1. dnf install snappy-devel
2. grep "#define SNAPPY_" /usr/include/snappy-stubs-public.h

Actual results:
#define SNAPPY_MAJOR 
#define SNAPPY_MINOR 
#define SNAPPY_PATCHLEVEL 
#define SNAPPY_VERSION \

Expected results:
#define SNAPPY_MAJOR 1
#define SNAPPY_MINOR 1
#define SNAPPY_PATCHLEVEL 7
#define SNAPPY_VERSION \


Additional info:
Works as expected on Fedora 27

Comment 1 Martin Gieseking 2017-12-20 10:13:00 UTC
Thanks for the report. Fixed in snappy-1.1.7-2.fc28.

Comment 2 Sergey Avseyev 2017-12-20 10:17:29 UTC
Thanks, Martin. Will you notify upstream? This issue seems like still not fixed in master branch.

Comment 3 Sergey Avseyev 2017-12-20 10:38:48 UTC
Reported to upstream as https://github.com/google/snappy/pull/61

Comment 4 Sergey Avseyev 2017-12-20 10:39:49 UTC
Sorry, changing resolution back (scrolled on the select control by mistake)

Comment 5 Martin Gieseking 2017-12-20 10:50:39 UTC
Thanks for notifying upstream. I was just about to do so too. :-)


Note You need to log in before you can comment on or make changes to this bug.