Bug 1530059

Summary:	Review Request: python-rply - Port David Beazley's PLY to RPython
Product:	[Fedora] Fedora	Reporter:	Igor Gnatenko <ignatenko>
Component:	Package Review	Assignee:	Neal Gompa <ngompa13>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	ngompa13, package-review
Target Milestone:	---	Flags:	ngompa13: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-01-03 16:24:26 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1530060

Description Igor Gnatenko 2018-01-01 17:10:46 UTC

Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/python-rply.spec
SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/python-rply-0.7.5-1.fc28.src.rpm
Description: Port David Beazley's PLY to RPython.
Fedora Account System Username: ignatenkobrain

Comment 1 Neal Gompa 2018-01-01 17:15:19 UTC

Taking this review.

Comment 2 Neal Gompa 2018-01-01 17:17:27 UTC

Review notes:

[x] Follows Fedora Python package naming
[x] License is correctly marked and license file is properly installed
[x] Builds and installs correctly
[!] Missing %python_provide macro for flavor subpackages

From what I can tell, the only thing missing is the %python_provide macro. Please add that.

Comment 3 Igor Gnatenko 2018-01-01 17:19:21 UTC

Fixed.

Comment 4 Neal Gompa 2018-01-01 17:19:39 UTC

Looks good!

PACKAGE APPROVED.