Bug 1530059 - Review Request: python-rply - Port David Beazley's PLY to RPython
Summary: Review Request: python-rply - Port David Beazley's PLY to RPython
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1530060
TreeView+ depends on / blocked
 
Reported: 2018-01-01 17:10 UTC by Igor Gnatenko
Modified: 2018-01-03 16:24 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2018-01-03 16:24:26 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+

Attachments (Terms of Use)

Description Igor Gnatenko 2018-01-01 17:10:46 UTC 
Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/python-rply.spec
SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/python-rply-0.7.5-1.fc28.src.rpm
Description: Port David Beazley's PLY to RPython.
Fedora Account System Username: ignatenkobrain
Comment 1 Neal Gompa 2018-01-01 17:15:19 UTC 
Taking this review.
Comment 2 Neal Gompa 2018-01-01 17:17:27 UTC 
Review notes:

[x] Follows Fedora Python package naming
[x] License is correctly marked and license file is properly installed
[x] Builds and installs correctly
[!] Missing %python_provide macro for flavor subpackages

From what I can tell, the only thing missing is the %python_provide macro. Please add that.
Comment 3 Igor Gnatenko 2018-01-01 17:19:21 UTC 
Fixed.
Comment 4 Neal Gompa 2018-01-01 17:19:39 UTC 
Looks good!

PACKAGE APPROVED.
Note You need to log in before you can comment on or make changes to this bug.