Bug 1530574

Summary:	pull request
Product:	[Fedora] Fedora	Reporter:	Tomasz Kłoczko <kloczko.tomasz>
Component:	cmake	Assignee:	Orion Poplawski <orion>
Status:	CLOSED WONTFIX	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	28	CC:	besser82, jreznik, orion, rdieter, walter.pete
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-07-27 13:48:09 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Tomasz Kłoczko 2018-01-03 11:32:38 UTC

Copy of the %changelog entry:

* Tue Jan 03 2018 Tomasz Kłoczko <kloczek> - 3.10.1-9
- removed some redundant %%ifing
- drop all gui subpackage %%post, %%postun and %%posttrans as update gtk icons
  and mime types caches is done over file triggers
  (look on "rpm -q --filetriggers hicolor-icon-theme shared-mime-info")
- drop cmake_enables_test %bcond as %%check is by default enabled, and if someone
  wants to disable it during build all what is needed is add --nocheck option
- shorten all %%bconds names to make then easier to read

Comment 1 Tomasz Kłoczko 2018-01-16 07:14:52 UTC

May I ask package maintainer to respond?

Comment 2 Tomasz Kłoczko 2018-01-30 21:11:44 UTC

Forgot to add URL to pull request https://src.fedoraproject.org/rpms/cmake/pull-request/2

Comment 3 Rex Dieter 2018-01-31 15:01:16 UTC

I'll let others comment more, I think besser82 added most of the conditionals, for example.


Though honestly, many of the changes included here are cosmetic and a subjective matter of taste... (some I personally dislike like moving comments from their own line to appending them to the end)... so if it matters, I'm -1 overall

Comment 4 Igor Gnatenko 2018-02-08 13:09:54 UTC

I'm -1 as well.

Comment 5 Fedora End Of Life 2018-02-20 15:28:48 UTC

This bug appears to have been reported against 'rawhide' during the Fedora 28 development cycle.
Changing version to '28'.

Comment 6 Rex Dieter 2018-07-27 13:48:09 UTC

Given 2 -1's I'm closing this (PR already closed)