Bug 1530574 - pull request
Summary: pull request
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: cmake
Version: 28
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Orion Poplawski
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-01-03 11:32 UTC by Tomasz Kłoczko
Modified: 2018-07-27 13:48 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-07-27 13:48:09 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Tomasz Kłoczko 2018-01-03 11:32:38 UTC
Copy of the %changelog entry:

* Tue Jan 03 2018 Tomasz Kłoczko <kloczek> - 3.10.1-9
- removed some redundant %%ifing
- drop all gui subpackage %%post, %%postun and %%posttrans as update gtk icons
  and mime types caches is done over file triggers
  (look on "rpm -q --filetriggers hicolor-icon-theme shared-mime-info")
- drop cmake_enables_test %bcond as %%check is by default enabled, and if someone
  wants to disable it during build all what is needed is add --nocheck option
- shorten all %%bconds names to make then easier to read

Comment 1 Tomasz Kłoczko 2018-01-16 07:14:52 UTC
May I ask package maintainer to respond?

Comment 2 Tomasz Kłoczko 2018-01-30 21:11:44 UTC
Forgot to add URL to pull request https://src.fedoraproject.org/rpms/cmake/pull-request/2

Comment 3 Rex Dieter 2018-01-31 15:01:16 UTC
I'll let others comment more, I think besser82 added most of the conditionals, for example.


Though honestly, many of the changes included here are cosmetic and a subjective matter of taste... (some I personally dislike like moving comments from their own line to appending them to the end)... so if it matters, I'm -1 overall

Comment 4 Igor Gnatenko 2018-02-08 13:09:54 UTC
I'm -1 as well.

Comment 5 Fedora End Of Life 2018-02-20 15:28:48 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 28 development cycle.
Changing version to '28'.

Comment 6 Rex Dieter 2018-07-27 13:48:09 UTC
Given 2 -1's I'm closing this (PR already closed)


Note You need to log in before you can comment on or make changes to this bug.