Bug 1531054

Summary: Review Request: perl-Types-URI - Type constraints and coercions for URIs
Product: [Fedora] Fedora Reporter: Petr Pisar <ppisar>
Component: Package ReviewAssignee: Jitka Plesnikova <jplesnik>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: jplesnik, package-review
Target Milestone: ---Flags: jplesnik: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: perl-Types-URI-0.006-1.fc28 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-01-04 16:14:18 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1531051    
Bug Blocks: 1531085    

Description Petr Pisar 2018-01-04 13:29:41 UTC 
Spec URL: https://ppisar.fedorapeople.org/perl-Types-URI/perl-Types-URI.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Types-URI/perl-Types-URI-0.006-1.fc28.src.rpm
Description:
Types::URI is a type constraint Perl library suitable for use with Moo/Moose
attributes, Kavorka sub signatures, and so forth.

Fedora Account System Username: ppisar
Comment 1 Jitka Plesnikova 2018-01-04 15:46:56 UTC 
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Types-URI-0.006-1.fc28.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.26.1)
      1 perl(strict)
      1 perl(Type::Library) >= 1.000000
      1 perl(Types::Path::Tiny)
      1 perl(Types::Standard)
      1 perl(Types::UUID)
      1 perl(URI)
      1 perl(URI::data)
      1 perl(URI::file)
      1 perl(URI::FromHash)
      1 perl(URI::WithBase)
      1 perl(:VERSION) >= 5.8.0
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Types-URI-0.006-1.fc28.noarch.rpm | sort | uniq -c
      1 perl(Types::URI) = 0.006
      1 perl-Types-URI = 0.006-1.fc28
Binary provides are Ok.

$ rpmlint ./perl-Types-URI*
perl-Types-URI.noarch: W: spelling-error Summary(en_US) coercions -> coercion, coercion's, coercion s
perl-Types-URI.noarch: W: invalid-license Artistic
perl-Types-URI.src: W: spelling-error Summary(en_US) coercions -> coercion, coercion's, coercion s
perl-Types-URI.src: W: invalid-license Artistic
2 packages and 1 specfiles checked; 0 errors, 4 warnings.
Rpmlint is ok (invalid license warnings)

The package looks good.
Approved.
Comment 2 Gwyn Ciesla 2018-01-04 15:56:42 UTC 
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Types-URI
Comment 3 Petr Pisar 2018-01-04 16:14:18 UTC 
Thank you for the review and the repository.