Spec URL: https://ppisar.fedorapeople.org/perl-URI-NamespaceMap/perl-URI-NamespaceMap.spec SRPM URL: https://ppisar.fedorapeople.org/perl-URI-NamespaceMap/perl-URI-NamespaceMap-1.04-1.fc28.src.rpm Description: These Perl modules provide a database system for managing URI name spaces in an object-oriented manner. Fedora Account System Username: ppisar
URL and Source addresses are Ok. Source archive (SHA-256: 6f98ae31d80a95cd6ef863d16830c844adb5269d2128ec122569eda99d6629c5) is original. Ok. Summary Ok. Description Ok. License verified from lib/URI/NamespaceMap.pm and LICENSE. Ok. No XS code, noarch BuildArch is Ok. All tests pass. Ok. $ rpmlint perl-URI-NamespaceMap.spec perl-URI-NamespaceMap-1.04-1.fc28.src.rpm review-perl-URI-NamespaceMap/results/perl-URI-NamespaceMap-1.04-1.fc28.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpm -q -lv -p perl-URI-NamespaceMap-1.04-1.fc28.noarch.rpm drwxr-xr-x 2 root root 0 janv. 4 16:57 /usr/share/doc/perl-URI-NamespaceMap -rw-r--r-- 1 root root 1554 juil. 8 2017 /usr/share/doc/perl-URI-NamespaceMap/COPYRIGHT -rw-r--r-- 1 root root 277 juil. 8 2017 /usr/share/doc/perl-URI-NamespaceMap/CREDITS -rw-r--r-- 1 root root 3138 juil. 8 2017 /usr/share/doc/perl-URI-NamespaceMap/Changes -rw-r--r-- 1 root root 3889 juil. 8 2017 /usr/share/doc/perl-URI-NamespaceMap/README drwxr-xr-x 2 root root 0 janv. 4 16:57 /usr/share/licenses/perl-URI-NamespaceMap -rw-r--r-- 1 root root 18482 juil. 8 2017 /usr/share/licenses/perl-URI-NamespaceMap/LICENSE -rw-r--r-- 1 root root 1609 janv. 4 16:57 /usr/share/man/man3/Types::Namespace.3pm.gz -rw-r--r-- 1 root root 1778 janv. 4 16:57 /usr/share/man/man3/URI::Namespace.3pm.gz -rw-r--r-- 1 root root 2944 janv. 4 16:57 /usr/share/man/man3/URI::NamespaceMap.3pm.gz -rw-r--r-- 1 root root 1860 janv. 4 16:57 /usr/share/man/man3/URI::NamespaceMap::ReservedLocalParts.3pm.gz drwxr-xr-x 2 root root 0 janv. 4 16:57 /usr/share/perl5/vendor_perl/Types -rw-r--r-- 1 root root 2054 juil. 8 2017 /usr/share/perl5/vendor_perl/Types/Namespace.pm drwxr-xr-x 2 root root 0 janv. 4 16:57 /usr/share/perl5/vendor_perl/URI -rw-r--r-- 1 root root 2893 juil. 8 2017 /usr/share/perl5/vendor_perl/URI/Namespace.pm drwxr-xr-x 2 root root 0 janv. 4 16:57 /usr/share/perl5/vendor_perl/URI/NamespaceMap -rw-r--r-- 1 root root 10388 juil. 8 2017 /usr/share/perl5/vendor_perl/URI/NamespaceMap.pm -rw-r--r-- 1 root root 2389 juil. 8 2017 /usr/share/perl5/vendor_perl/URI/NamespaceMap/ReservedLocalParts.pm File permissions and layout are Ok. $ rpm -q --requires -p perl-URI-NamespaceMap-1.04-1.fc28.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.26.1) 1 perl(Carp) 1 perl(IRI) >= 0.003 1 perl(List::Util) 1 perl(Module::Load::Conditional) 1 perl(Moo) >= 1.006000 1 perl(namespace::autoclean) 1 perl(Scalar::Util) 1 perl(strict) 1 perl(Sub::Quote) 1 perl(Try::Tiny) 1 perl(Type::Library) 1 perl(Types::Namespace) >= 0.004 1 perl(Types::Standard) 1 perl(Types::URI) 1 perl(URI) 1 perl(URI::Namespace) 1 perl(URI::NamespaceMap) 1 perl(URI::NamespaceMap::ReservedLocalParts) 1 perl(warnings) 1 perl(XML::CommonNS) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p perl-URI-NamespaceMap-1.04-1.fc28.noarch.rpm perl(Types::Namespace) = 1.04 perl(URI::Namespace) = 1.04 perl(URI::NamespaceMap) = 1.04 perl(URI::NamespaceMap::ReservedLocalParts) = 1.04 perl-URI-NamespaceMap = 1.04-1.fc28 Binary provides are Ok. Package builds in Mock. Ok The package is in line with Fedora and Perl packaging guidelines. Resolution: Package approved.
Sorrx for the "mid air collision", jplesnik, I was finishing the review.
(fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-URI-NamespaceMap
Thank you for the review and the repository.