Bug 1533994

For the backport to OSP12 

+++ This bug was initially created as a clone of Bug #1525729 +++

Description of problem:
We expose the ability to customize the Keystone region name but it is not being correctly used for all services. Additionally there are instances of RegionOne (the upstream default for this) within the configuration files of deployed services.

Version-Release number of selected component (if applicable):
openstack-tripleo-validations-5.1.2-1.el7ost.noarch
openstack-tripleo-puppet-elements-5.3.2-1.el7ost.noarch
openstack-tripleo-image-elements-5.3.1-1.el7ost.noarch
python-tripleoclient-5.4.3-1.el7ost.noarch
openstack-tripleo-0.0.8-0.2.4de13b3git.el7ost.noarch
puppet-tripleo-5.6.4-2.el7ost.noarch
openstack-tripleo-ui-1.2.1-1.el7ost.noarch
openstack-tripleo-heat-templates-5.3.3-1.el7ost.noarch
openstack-tripleo-common-5.4.4-1.el7ost.noarch


How reproducible:
always

Steps to Reproduce:
1. Deploy overcloud with the following environment file:

parameter_defaults:
  KeystoneRegion: 'foo'

2. Inspect configurations for incorrect region_name settings
3.

Actual results:

[root@overcloud-controller-0 ~]# grep regionOne -ir /etc
/etc/saf/enabler_conf.ini:#region_name = RegionOne
/etc/nova/nova.conf:region_name=RegionOne
/etc/neutron/neutron_lbaas.conf:#region = RegionOne
/etc/aodh/aodh.conf:region_name = regionOne
/etc/puppet/hieradata/service_configs.yaml:aodh::auth::auth_region: regionOne
/etc/glance/glance-cache.conf:os_region_name=RegionOne
/etc/glance/glance-api.conf:os_region_name=RegionOne

[root@overcloud-compute-0 ~]# grep regionOne -ir /etc
/etc/saf/enabler_conf.ini:#region_name = RegionOne
/etc/nova/nova.conf:region_name=RegionOne
/etc/neutron/neutron_lbaas.conf:#region = RegionOne

Expected results:

region_name should match KeystoneRegion


Additional info:

--- Additional comment from David Peacock on 2018-01-08 18:26:31 EST ---

Reproduced this, with slightly differing results on my env.

Controller:

/etc/trove/trove-taskmanager.conf:#os_region_name = RegionOne
/etc/trove/trove.conf:#os_region_name = RegionOne
/etc/barbican/barbican-functional.conf:#region_name=RegionOne

[... keystone catalog entries snipped]

/etc/nova/nova.conf:#region_name=RegionOne
/etc/neutron/neutron_lbaas.conf:#region = RegionOne
/etc/skydive/skydive.yml:  region_name: RegionOne
/etc/puppet/hieradata/service_configs.json:    "panko::auth::auth_region": "regionOne",

Compute:

/etc/trove/trove-taskmanager.conf:#os_region_name = RegionOne
/etc/trove/trove.conf:#os_region_name = RegionOne
/etc/barbican/barbican-functional.conf:#region_name=RegionOne

[... keystone catalog entries snipped]

/etc/nova/nova.conf:#region_name=RegionOne
/etc/neutron/neutron_lbaas.conf:#region = RegionOne
/etc/openstack-dashboard/local_settings:#    OPENSTACK_KEYSTONE_URL: 'RegionOne'
/etc/skydive/skydive.yml:  region_name: RegionOne

--- Additional comment from David Peacock on 2018-01-08 19:07:24 EST ---

Controller most concern:

/etc/skydive/skydive.yml:  region_name: RegionOne
/etc/puppet/hieradata/service_configs.json:    "panko::auth::auth_region": "regionOne",

Compute most concern:

/etc/skydive/skydive.yml:  region_name: RegionOne

--- Additional comment from David Peacock on 2018-01-09 12:11:19 EST ---

Patch for the panko auth region aspect submitted upstream for review.  Once this has been merged, I'll proceed with downstream backports for panko auth and nova.

https://review.openstack.org/532255

--- Additional comment from David Peacock on 2018-01-11 11:09:29 EST ---

Upstream patch merged.

Currently proceeding to reproduce downstream.  RHOSP12 first, then I'll go down the version order to 10.