Bug 1535006

I believe that's solved by https://gerrit.ovirt.org/#/c/86180/
Please reopen if I'm wrong.

Hi Dan, 

First of all, please move to ON_QA once it is in the build. 
Second, the patch attached include no bug url.
Third, i don't think it solves our problem with passing the custom to the provider. The bug exist on latest d/s 4.2.1.2-0.1.el7 , nothing changed.

Let me be more precise. I believe that this is solved by ovirt-provider-ovn-1.2.5 (which is already available d/s). Please retest.

(In reply to Dan Kenigsberg from comment #3)
> Let me be more precise. I believe that this is solved by
> ovirt-provider-ovn-1.2.5 (which is already available d/s). Please retest.

Again, i tested the latest build 4.2.1.2-0.1.el7 which includes ovirt-provider-ovn-1.2.5-1.el7ev.noarch.

Dominik fails to reproduce the bug with current versions. Would you agree to reproduce it on your setup, and ping him?

(In reply to Dan Kenigsberg from comment #5)
> Dominik fails to reproduce the bug with current versions. Would you agree to
> reproduce it on your setup, and ping him?

Sure

Created attachment 1389099 [details]
additional ovn logs

> 1. Create vlan logical network in the DC. Attach the logical network
> to the host. 
> 2. Create ovn network and check the new 'Connect to
> physical network' check box, choose custom and set vdsm name of the
> logical network 

Here is the problem. If a custom network is chosen, it is required to define the VLAN manually in the "Enable VLAN tagging" input.
I leave the bug open until we decided if this should be or is already documented.

> 3. Run VM with the ovn network
> 
> Actual results:
> VM get the wrong IP> looks like the correct tag isn't passed to the
> provider

(In reply to Dominik Holler from comment #8)
> > 1. Create vlan logical network in the DC. Attach the logical network
> > to the host. 
> > 2. Create ovn network and check the new 'Connect to
> > physical network' check box, choose custom and set vdsm name of the
> > logical network 
> 
> Here is the problem. If a custom network is chosen, it is required to define
> the VLAN manually in the "Enable VLAN tagging" input.
> I leave the bug open until we decided if this should be or is already
> documented.
> 
> > 3. Run VM with the ovn network
> > 
> > Actual results:
> > VM get the wrong IP> looks like the correct tag isn't passed to the
> > provider

Hi
So you say that if using custom, we need to set the same vlan tag both on the physnet network + on the ovn network?

(In reply to Michael Burman from comment #9)
> (In reply to Dominik Holler from comment #8)
> > > 1. Create vlan logical network in the DC. Attach the logical network
> > > to the host. 
> > > 2. Create ovn network and check the new 'Connect to
> > > physical network' check box, choose custom and set vdsm name of the
> > > logical network 
> > 
> > Here is the problem. If a custom network is chosen, it is required to define
> > the VLAN manually in the "Enable VLAN tagging" input.
> > I leave the bug open until we decided if this should be or is already
> > documented.
> > 
> > > 3. Run VM with the ovn network
> > > 
> > > Actual results:
> > > VM get the wrong IP> looks like the correct tag isn't passed to the
> > > provider
> 
> Hi
> So you say that if using custom, we need to set the same vlan tag both on
> the physnet network + on the ovn network?

Yes.

Hi Ales,

I'm not sure how to test this fix? it was a bit changed from the original report. 
Please explain how to test the custom+physnet with exact steps.

Thanks!

Hi Micheal,

1) When you choose create on external provider. VLAN and DNS inputs should be disabled.

2) Both should stay disabled until you choose custom physnet. Then only the VLAN should be enabled.

(In reply to Ales Musil from comment #12)
> Hi Micheal,
> 
> 1) When you choose create on external provider. VLAN and DNS inputs should
> be disabled.
> 
> 2) Both should stay disabled until you choose custom physnet. Then only the
> VLAN should be enabled.

Thanks Ales,
Ok and then, after step 2? do i need to set vlan for the custom? i thought we agree that custom and physnet should behave the same..

Yes, you still need to set vlan for custom manually. Sadly there is not much we can do about it.

Based on comments 13+14 and now when BZ 1551971 is fixed this report is 
Verified on 4.2.2.4-0.1.el7

This bugzilla is included in oVirt 4.2.2 release, published on March 28th 2018.

Since the problem described in this bug report should be
resolved in oVirt 4.2.2 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.