Bug 1535006 - ovn localnet: attachment of ovn network to Custom data center network is not passed to provider
Summary: ovn localnet: attachment of ovn network to Custom data center network is not ...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: BLL.Network
Version: 4.2.1.1
Hardware: x86_64
OS: Linux
medium
medium
Target Milestone: ovirt-4.2.2
: ---
Assignee: Ales Musil
QA Contact: Michael Burman
URL:
Whiteboard:
Depends On: 1551971
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-01-16 12:59 UTC by Michael Burman
Modified: 2018-03-29 11:20 UTC (History)
8 users (show)

Fixed In Version: ovirt-engine-4.2.2.2
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-03-29 11:20:00 UTC
oVirt Team: Network
Embargoed:
rule-engine: ovirt-4.2+
ylavi: exception+


Attachments (Terms of Use)
Logs (1.42 MB, application/x-gzip)
2018-01-16 12:59 UTC, Michael Burman
no flags Details
additional ovn logs (7.51 KB, text/plain)
2018-01-31 17:02 UTC, Dominik Holler
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 86178 0 master MERGED webadmin: Disable VLAN and DNS editing with external network 2018-02-21 12:15:50 UTC
oVirt gerrit 88215 0 ovirt-engine-4.2 MERGED webadmin: Disable VLAN and DNS editing with external network 2018-03-01 10:32:36 UTC

Description Michael Burman 2018-01-16 12:59:48 UTC
Created attachment 1381987 [details]
Logs

Description of problem:
ovn localnet: attachment of ovn network to Custom data center network is not passed to provider.

Looks like the custom name is not passed to the provider and VM get the wrong IP on start VM.

Version-Release number of selected component (if applicable):
4.2.1.1-0.1.el7

How reproducible:
100%

Steps to Reproduce:
1. Create vlan logical network in the DC. Attach the logical network to the host.
2. Create ovn network and check the new 'Connect to physical network' check box, choose custom and set vdsm name of the logical network
3. Run VM with the ovn network

Actual results:
VM get the wrong IP> looks like the correct tag isn't passed to the provider

Expected results:
Custom physnet should work

Comment 1 Dan Kenigsberg 2018-01-18 20:02:23 UTC
I believe that's solved by https://gerrit.ovirt.org/#/c/86180/
Please reopen if I'm wrong.

Comment 2 Michael Burman 2018-01-21 14:59:34 UTC
Hi Dan, 

First of all, please move to ON_QA once it is in the build. 
Second, the patch attached include no bug url.
Third, i don't think it solves our problem with passing the custom to the provider. The bug exist on latest d/s 4.2.1.2-0.1.el7 , nothing changed.

Comment 3 Dan Kenigsberg 2018-01-21 20:03:34 UTC
Let me be more precise. I believe that this is solved by ovirt-provider-ovn-1.2.5 (which is already available d/s). Please retest.

Comment 4 Michael Burman 2018-01-22 06:10:46 UTC
(In reply to Dan Kenigsberg from comment #3)
> Let me be more precise. I believe that this is solved by
> ovirt-provider-ovn-1.2.5 (which is already available d/s). Please retest.

Again, i tested the latest build 4.2.1.2-0.1.el7 which includes ovirt-provider-ovn-1.2.5-1.el7ev.noarch.

Comment 5 Dan Kenigsberg 2018-01-31 12:53:10 UTC
Dominik fails to reproduce the bug with current versions. Would you agree to reproduce it on your setup, and ping him?

Comment 6 Michael Burman 2018-01-31 13:32:55 UTC
(In reply to Dan Kenigsberg from comment #5)
> Dominik fails to reproduce the bug with current versions. Would you agree to
> reproduce it on your setup, and ping him?

Sure

Comment 7 Dominik Holler 2018-01-31 17:02:47 UTC
Created attachment 1389099 [details]
additional ovn logs

Comment 8 Dominik Holler 2018-01-31 17:17:45 UTC
> 1. Create vlan logical network in the DC. Attach the logical network
> to the host. 
> 2. Create ovn network and check the new 'Connect to
> physical network' check box, choose custom and set vdsm name of the
> logical network 

Here is the problem. If a custom network is chosen, it is required to define the VLAN manually in the "Enable VLAN tagging" input.
I leave the bug open until we decided if this should be or is already documented.

> 3. Run VM with the ovn network
> 
> Actual results:
> VM get the wrong IP> looks like the correct tag isn't passed to the
> provider

Comment 9 Michael Burman 2018-02-01 09:09:09 UTC
(In reply to Dominik Holler from comment #8)
> > 1. Create vlan logical network in the DC. Attach the logical network
> > to the host. 
> > 2. Create ovn network and check the new 'Connect to
> > physical network' check box, choose custom and set vdsm name of the
> > logical network 
> 
> Here is the problem. If a custom network is chosen, it is required to define
> the VLAN manually in the "Enable VLAN tagging" input.
> I leave the bug open until we decided if this should be or is already
> documented.
> 
> > 3. Run VM with the ovn network
> > 
> > Actual results:
> > VM get the wrong IP> looks like the correct tag isn't passed to the
> > provider

Hi
So you say that if using custom, we need to set the same vlan tag both on the physnet network + on the ovn network?

Comment 10 Dominik Holler 2018-02-01 09:11:15 UTC
(In reply to Michael Burman from comment #9)
> (In reply to Dominik Holler from comment #8)
> > > 1. Create vlan logical network in the DC. Attach the logical network
> > > to the host. 
> > > 2. Create ovn network and check the new 'Connect to
> > > physical network' check box, choose custom and set vdsm name of the
> > > logical network 
> > 
> > Here is the problem. If a custom network is chosen, it is required to define
> > the VLAN manually in the "Enable VLAN tagging" input.
> > I leave the bug open until we decided if this should be or is already
> > documented.
> > 
> > > 3. Run VM with the ovn network
> > > 
> > > Actual results:
> > > VM get the wrong IP> looks like the correct tag isn't passed to the
> > > provider
> 
> Hi
> So you say that if using custom, we need to set the same vlan tag both on
> the physnet network + on the ovn network?

Yes.

Comment 11 Michael Burman 2018-03-06 07:09:23 UTC
Hi Ales,

I'm not sure how to test this fix? it was a bit changed from the original report. 
Please explain how to test the custom+physnet with exact steps.

Thanks!

Comment 12 Ales Musil 2018-03-06 11:54:06 UTC
Hi Micheal,

1) When you choose create on external provider. VLAN and DNS inputs should be disabled.

2) Both should stay disabled until you choose custom physnet. Then only the VLAN should be enabled.

Comment 13 Michael Burman 2018-03-06 12:29:38 UTC
(In reply to Ales Musil from comment #12)
> Hi Micheal,
> 
> 1) When you choose create on external provider. VLAN and DNS inputs should
> be disabled.
> 
> 2) Both should stay disabled until you choose custom physnet. Then only the
> VLAN should be enabled.

Thanks Ales,
Ok and then, after step 2? do i need to set vlan for the custom? i thought we agree that custom and physnet should behave the same..

Comment 14 Ales Musil 2018-03-06 12:36:28 UTC
Yes, you still need to set vlan for custom manually. Sadly there is not much we can do about it.

Comment 15 Michael Burman 2018-03-18 13:11:13 UTC
Based on comments 13+14 and now when BZ 1551971 is fixed this report is 
Verified on 4.2.2.4-0.1.el7

Comment 16 Sandro Bonazzola 2018-03-29 11:20:00 UTC
This bugzilla is included in oVirt 4.2.2 release, published on March 28th 2018.

Since the problem described in this bug report should be
resolved in oVirt 4.2.2 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.