Bug 1535010
| Summary: | JavaScript-UI: Wrong behavior of `display on button` checkbox while editing custom group form | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | Yadnyawalk Tale <ytale> | ||||
| Component: | UI - OPS | Assignee: | Brian McLaughlin <bmclaugh> | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Yadnyawalk Tale <ytale> | ||||
| Severity: | high | Docs Contact: | |||||
| Priority: | high | ||||||
| Version: | 5.9.0 | CC: | cpelland, hkataria, lavenel, mpovolny, obarenbo, simaishi | ||||
| Target Milestone: | GA | Keywords: | TestOnly, ZStream | ||||
| Target Release: | 5.10.0 | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | ui:custom_button:button:generic_object | ||||||
| Fixed In Version: | 5.10.0.0 | Doc Type: | If docs needed, set a value | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | |||||||
| : | 1553214 (view as bug list) | Environment: | |||||
| Last Closed: | 2019-02-11 14:08:19 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | Bug | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | CFME Core | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 1553214 | ||||||
| Attachments: |
|
||||||
Please note BZ1535021 somehow related to this issue but different than current one. Opened new bz since it cover large permutations. *** Bug 1535021 has been marked as a duplicate of this bug. *** New commit detected on ManageIQ/manageiq-ui-classic/master: https://github.com/ManageIQ/manageiq-ui-classic/commit/958518ba0b08c640086705c226822390a50a719a commit 958518ba0b08c640086705c226822390a50a719a Author: Brian McLaughlin <bmclaugh> AuthorDate: Wed Jan 31 16:17:58 2018 -0500 Commit: Brian McLaughlin <bmclaugh> CommitDate: Mon Feb 12 08:09:29 2018 -0500 Fix logic to correctly check 'display on button' checkbox https://bugzilla.redhat.com/show_bug.cgi?id=1535010 app/views/shared/buttons/_ab_list.html.haml | 2 +- app/views/shared/buttons/_group_form.html.haml | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) New commit detected on ManageIQ/manageiq-ui-classic/master: https://github.com/ManageIQ/manageiq-ui-classic/commit/86f69d107bf3684ce3cd273fdb39bb796c418823 commit 86f69d107bf3684ce3cd273fdb39bb796c418823 Author: Brian McLaughlin <bmclaugh> AuthorDate: Mon Feb 12 08:45:15 2018 -0500 Commit: Brian McLaughlin <bmclaugh> CommitDate: Mon Feb 12 08:45:15 2018 -0500 Refactoring https://bugzilla.redhat.com/show_bug.cgi?id=1535010 app/views/shared/buttons/_ab_list.html.haml | 2 +- app/views/shared/buttons/_group_form.html.haml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) 'Display on Button' checkbox is now responsive against 'Save' button. I can save and edit group and button forms now. Verified on: 5.10.0.17.20180927011235_1b5cf54 Thanks! |
Created attachment 1382000 [details] checkbox_wrong_behavior Description of problem: JavaScript/UI bug of related to custom group. Version-Release number of selected component (if applicable): 5.9.0.16.20180109204148_7ac9852 (also on upstream master.20171206231308_1bfd713) How reproducible: 100% Steps to Reproduce: 1. Navigate to Automation > Automate > Customization > Buttons accordion 2. In VM and Instance option, add custom group 3. While adding group, select `Display on Button` and save it 4. Select that button and edit it, try to uncheck and save that form Actual results: If I have checked checkbox; I want to unchecked and save it , I am not able to do that. Expected results: Should save the form if any changes are made (like unchecked or check) Additional info: Found this behavior is with every custom group options in button accordion (Automation>Automate>Customization>Buttons) Custom button working good (respective to check, unchecked behavior only)