Bug 1535010 - JavaScript-UI: Wrong behavior of `display on button` checkbox while editing custom group form
Summary: JavaScript-UI: Wrong behavior of `display on button` checkbox while editing c...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.9.0
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: GA
: 5.10.0
Assignee: Brian McLaughlin
QA Contact: Yadnyawalk Tale
URL:
Whiteboard: ui:custom_button:button:generic_object
: 1535021 (view as bug list)
Depends On:
Blocks: 1553214
TreeView+ depends on / blocked
 
Reported: 2018-01-16 13:14 UTC by Yadnyawalk Tale
Modified: 2019-02-11 14:08 UTC (History)
6 users (show)

Fixed In Version: 5.10.0.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1553214 (view as bug list)
Environment:
Last Closed: 2019-02-11 14:08:19 UTC
Category: Bug
Cloudforms Team: CFME Core
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
checkbox_wrong_behavior (863.58 KB, image/gif)
2018-01-16 13:14 UTC, Yadnyawalk Tale
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1535021 0 high CLOSED UI: `Display on button` checkbox not working while adding custom group 2021-02-22 00:41:40 UTC

Internal Links: 1535021

Description Yadnyawalk Tale 2018-01-16 13:14:40 UTC
Created attachment 1382000 [details]
checkbox_wrong_behavior

Description of problem:
JavaScript/UI bug of related to custom group. 

Version-Release number of selected component (if applicable):
5.9.0.16.20180109204148_7ac9852 
(also on upstream master.20171206231308_1bfd713)

How reproducible:
100%

Steps to Reproduce:
1. Navigate to Automation > Automate > Customization > Buttons accordion
2. In VM and Instance option, add custom group
3. While adding group, select `Display on Button` and save it
4. Select that button and edit it, try to uncheck and save that form
 
Actual results:
If I have checked checkbox; I want to unchecked and save it , I am not able to do that. 

Expected results:
Should save the form if any changes are made (like unchecked or check)

Additional info:
Found this behavior is with every custom group options in button accordion (Automation>Automate>Customization>Buttons)

Custom button working good (respective to check, unchecked behavior only)

Comment 1 Yadnyawalk Tale 2018-01-16 13:28:51 UTC
Please note BZ1535021 somehow related to this issue but different than current one. Opened new bz since it cover large permutations.

Comment 3 Harpreet Kataria 2018-01-18 13:46:15 UTC
*** Bug 1535021 has been marked as a duplicate of this bug. ***

Comment 5 Brian McLaughlin 2018-02-07 13:24:22 UTC
https://github.com/ManageIQ/manageiq-ui-classic/pull/3383

Comment 6 CFME Bot 2018-02-15 12:03:51 UTC
New commit detected on ManageIQ/manageiq-ui-classic/master:
https://github.com/ManageIQ/manageiq-ui-classic/commit/958518ba0b08c640086705c226822390a50a719a

commit 958518ba0b08c640086705c226822390a50a719a
Author:     Brian McLaughlin <bmclaugh>
AuthorDate: Wed Jan 31 16:17:58 2018 -0500
Commit:     Brian McLaughlin <bmclaugh>
CommitDate: Mon Feb 12 08:09:29 2018 -0500

    Fix logic to correctly check 'display on button' checkbox
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1535010

 app/views/shared/buttons/_ab_list.html.haml    | 2 +-
 app/views/shared/buttons/_group_form.html.haml | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

Comment 7 CFME Bot 2018-02-15 12:03:56 UTC
New commit detected on ManageIQ/manageiq-ui-classic/master:
https://github.com/ManageIQ/manageiq-ui-classic/commit/86f69d107bf3684ce3cd273fdb39bb796c418823

commit 86f69d107bf3684ce3cd273fdb39bb796c418823
Author:     Brian McLaughlin <bmclaugh>
AuthorDate: Mon Feb 12 08:45:15 2018 -0500
Commit:     Brian McLaughlin <bmclaugh>
CommitDate: Mon Feb 12 08:45:15 2018 -0500

    Refactoring
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1535010

 app/views/shared/buttons/_ab_list.html.haml    | 2 +-
 app/views/shared/buttons/_group_form.html.haml | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comment 9 Yadnyawalk Tale 2018-10-03 16:17:00 UTC
'Display on Button' checkbox is now responsive against 'Save' button. I can save and edit group and button forms now. 

Verified on: 5.10.0.17.20180927011235_1b5cf54
Thanks!


Note You need to log in before you can comment on or make changes to this bug.