Bug 1535976

Summary:	[trello lo6HwQgu] Should validate Webhook Secret Key input when creating in web
Product:	OpenShift Container Platform	Reporter:	Xingxing Xia <xxia>
Component:	Management Console	Assignee:	Jakub Hadvig <jhadvig>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Yadan Pei <yapei>
Severity:	low	Docs Contact:
Priority:	medium
Version:	3.9.0	CC:	aos-bugs, jforrest, jokerman, mmccomas, spadgett
Target Milestone:	---
Target Release:	3.9.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-01-29 13:12:07 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Xingxing Xia 2018-01-18 11:29:15 UTC

Description of problem:
Should validate Webhook Secret Key input

Version-Release number of selected component (if applicable):
v3.9.0-0.20.0

How reproducible:
Always

Steps to Reproduce:
1. Go to secrets page, click Create Secret, select Webhook Secret type, input name
2. Input Webhook Secret Key "!@#$...." and click around

Actual results:
2. No prompt about the invalid key. "Create" can be clicked

Expected results:
2. Should have prompt. "Create" should be inactive

Additional info:

Comment 1 openshift-github-bot 2018-01-24 15:21:13 UTC

Commits pushed to master at https://github.com/openshift/origin-web-console

https://github.com/openshift/origin-web-console/commit/085c264a1a39cba0a9df4829da480ea054dbcaad
Bug 1535976 - Add validation to secret reference key and fix nform names in the create-secret form

https://github.com/openshift/origin-web-console/commit/e92e0cf54f9f9e2e6f50334f999de1ae655aeb39
Merge pull request #2680 from jhadvig/sec-form

Automatic merge from submit-queue.

Bug 1535976 - Fix input name in the create-secret form

Fixed wrong `input` names in the `create-secret.html` 
@jwforres PTAL

Comment 2 Jakub Hadvig 2018-01-24 16:13:37 UTC

Fixing PR: https://github.com/openshift/origin-web-console/pull/2680

Comment 4 Xingxing Xia 2018-01-29 04:39:38 UTC

Checked in v3.9.0-0.31.0. When input is invalid, it prompts:
Secret reference key must consist of lower-case, upper-case letters, numbers, dash, and underscore.
The key must have at least 8 characters.