Red Hat Bugzilla – Bug 1535976
[trello lo6HwQgu] Should validate Webhook Secret Key input when creating in web
Last modified: 2018-03-27 05:44:06 EDT
Description of problem: Should validate Webhook Secret Key input Version-Release number of selected component (if applicable): v3.9.0-0.20.0 How reproducible: Always Steps to Reproduce: 1. Go to secrets page, click Create Secret, select Webhook Secret type, input name 2. Input Webhook Secret Key "!@#$...." and click around Actual results: 2. No prompt about the invalid key. "Create" can be clicked Expected results: 2. Should have prompt. "Create" should be inactive Additional info:
Commits pushed to master at https://github.com/openshift/origin-web-console https://github.com/openshift/origin-web-console/commit/085c264a1a39cba0a9df4829da480ea054dbcaad Bug 1535976 - Add validation to secret reference key and fix nform names in the create-secret form https://github.com/openshift/origin-web-console/commit/e92e0cf54f9f9e2e6f50334f999de1ae655aeb39 Merge pull request #2680 from jhadvig/sec-form Automatic merge from submit-queue. Bug 1535976 - Fix input name in the create-secret form Fixed wrong `input` names in the `create-secret.html` @jwforres PTAL
Fixing PR: https://github.com/openshift/origin-web-console/pull/2680
Checked in v3.9.0-0.31.0. When input is invalid, it prompts: Secret reference key must consist of lower-case, upper-case letters, numbers, dash, and underscore. The key must have at least 8 characters.