Bug 1536629

Summary:	send job state and credentials from job
Product:	OpenShift Container Platform	Reporter:	Jesus M. Rodriguez <jesusr>
Component:	Service Broker	Assignee:	Jesus M. Rodriguez <jesusr>
Status:	CLOSED ERRATA	QA Contact:	Zihan Tang <zitang>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	3.9.0	CC:	aos-bugs, chezhang, jesusr
Target Milestone:	---
Target Release:	3.9.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	No Doc Update
Doc Text:	undefined	Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-03-28 14:21:18 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jesus M. Rodriguez 2018-01-19 19:12:57 UTC

As discussed on IRC with @eriknelson, while looking at the last operation PR it occurred to me it would make more sense to have the Job send through the JobState as part of its msg that is consumed by the subscribers rather than the subscribers deciding what state to set as can be seen here:

 https://github.com/openshift/ansible-service-broker/blob/master/pkg/broker/provision_subscriber.go#L55

I intended to include this change in my main PR for the last_operation feature, but after discussion, it probably makes more sense to have it as a standalone PR.

Upstream issue referenced:
https://github.com/openshift/ansible-service-broker/issues/608

Comment 1 Jesus M. Rodriguez 2018-01-19 19:14:19 UTC

PR: https://github.com/openshift/ansible-service-broker/pull/610

Comment 2 Zhang Cheng 2018-01-20 15:13:43 UTC

zitang, please try to trace and reproduce. Thanks.

Comment 3 Jesus M. Rodriguez 2018-01-20 15:26:59 UTC

(In reply to Zhang Cheng from comment #2)
> zitang, please try to trace and reproduce. Thanks.

This is an internal bug to capture a feature that entered late into the release cycle of the Ansible Broker. Largely internal restructuring of the work engine inside the broker.

Comment 4 Zhang Cheng 2018-01-20 15:47:20 UTC

So, is that means regression test is the good choice for us?

Comment 5 Jesus M. Rodriguez 2018-01-20 16:15:40 UTC

(In reply to Zhang Cheng from comment #4)
> So, is that means regression test is the good choice for us?

Yes, that is acceptable to test this bug. As long as there are no regressions introduced with the provision, deprovision, bind & unbind features this bug should be covered by those tests.

Comment 6 Jesus M. Rodriguez 2018-01-25 18:49:37 UTC

PR https://github.com/openshift/ansible-service-broker/pull/671

Comment 8 Zhang Cheng 2018-02-02 03:35:55 UTC

I'm changing status to "Modified" since downstream image not ready for test.

Comment 13 errata-xmlrpc 2018-03-28 14:21:18 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:0489