Red Hat Bugzilla – Bug 1536629
send job state and credentials from job
Last modified: 2018-03-28 10:22:07 EDT
As discussed on IRC with @eriknelson, while looking at the last operation PR it occurred to me it would make more sense to have the Job send through the JobState as part of its msg that is consumed by the subscribers rather than the subscribers deciding what state to set as can be seen here: https://github.com/openshift/ansible-service-broker/blob/master/pkg/broker/provision_subscriber.go#L55 I intended to include this change in my main PR for the last_operation feature, but after discussion, it probably makes more sense to have it as a standalone PR. Upstream issue referenced: https://github.com/openshift/ansible-service-broker/issues/608
PR: https://github.com/openshift/ansible-service-broker/pull/610
zitang, please try to trace and reproduce. Thanks.
(In reply to Zhang Cheng from comment #2) > zitang, please try to trace and reproduce. Thanks. This is an internal bug to capture a feature that entered late into the release cycle of the Ansible Broker. Largely internal restructuring of the work engine inside the broker.
So, is that means regression test is the good choice for us?
(In reply to Zhang Cheng from comment #4) > So, is that means regression test is the good choice for us? Yes, that is acceptable to test this bug. As long as there are no regressions introduced with the provision, deprovision, bind & unbind features this bug should be covered by those tests.
PR https://github.com/openshift/ansible-service-broker/pull/671
I'm changing status to "Modified" since downstream image not ready for test.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2018:0489