Bug 1536871

Summary: libnice: Add conditional for building with(out) gst010 / GStreamer 0.10 support
Product: [Fedora] Fedora Reporter: Tomas Hoger <thoger>
Component: libniceAssignee: Brian Pepple <bdpepple>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rawhideCC: bdpepple, cschalle, kdudka, philip, uraeus, wtaymans
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: libnice-0.1.13-11.fc28 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-01-29 15:46:12 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Add conditional for building with(out) gst010 / GStreamer 0.10 support
none
Add conditional for building with(out) gst010 / GStreamer 0.10 support none

Description Tomas Hoger 2018-01-21 20:47:20 UTC
Created attachment 1384128 [details]
Add conditional for building with(out) gst010 / GStreamer 0.10 support

Description of problem:

Add conditional that can be used to easily enable or disable building of plugin for gst010 / gstreamer 0.10.  The Fedora default remains unchanged, both gst / gstreamer 1.0 and gst010 / gstreamer 0.10 plugins are built.

Comment 6 Kamil Dudka 2018-01-23 11:05:50 UTC
Quickly searched Fedora repos, I can see nothing depending on libnice-gstreamer.  So it should be safe to remove GStreamer 0.10 support unconditionally?

Comment 7 Tomas Hoger 2018-01-23 12:24:19 UTC
That also solves my problem.  I only tried to be as non-invasive as possible, and I did not see an immediate need to drop gstreamer 0.10 support in Fedora.

Comment 8 Christian Fredrik Kalager Schaller 2018-01-23 12:32:02 UTC
I think that should be fine, I don't know of any active projects using this. But I added Wim Taymans to the CC so he can correct me if I am wrong.

Comment 9 Tomas Hoger 2018-01-24 15:22:07 UTC
Created attachment 1385645 [details]
Add conditional for building with(out) gst010 / GStreamer 0.10 support

Rewritten patch to use %bcond_with/%bcond_without and %if %{with gst010}.

Comment 10 Tomas Hoger 2018-01-24 15:25:06 UTC
https://src.fedoraproject.org/rpms/libnice/pull-request/1

For the patch in comment 9.

Comment 13 Kamil Dudka 2018-01-29 15:46:12 UTC
downstream commit:

https://src.fedoraproject.org/cgit/rpms/libnice.git/commit/?id=746455c9