Bug 1536871 - libnice: Add conditional for building with(out) gst010 / GStreamer 0.10 support
Summary: libnice: Add conditional for building with(out) gst010 / GStreamer 0.10 support
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: libnice
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
Assignee: Brian Pepple
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-01-21 20:47 UTC by Tomas Hoger
Modified: 2018-01-29 15:46 UTC (History)
6 users (show)

Fixed In Version: libnice-0.1.13-11.fc28
Clone Of:
Environment:
Last Closed: 2018-01-29 15:46:12 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)
Add conditional for building with(out) gst010 / GStreamer 0.10 support (2.43 KB, patch)
2018-01-21 20:47 UTC, Tomas Hoger 		no flags Details | Diff
Add conditional for building with(out) gst010 / GStreamer 0.10 support (2.41 KB, patch)
2018-01-24 15:22 UTC, Tomas Hoger 		no flags Details | Diff
Show Obsolete (1) View All

Description Tomas Hoger 2018-01-21 20:47:20 UTC 
Created attachment 1384128 [details]
Add conditional for building with(out) gst010 / GStreamer 0.10 support

Description of problem:

Add conditional that can be used to easily enable or disable building of plugin for gst010 / gstreamer 0.10.  The Fedora default remains unchanged, both gst / gstreamer 1.0 and gst010 / gstreamer 0.10 plugins are built.
Comment 6 Kamil Dudka 2018-01-23 11:05:50 UTC 
Quickly searched Fedora repos, I can see nothing depending on libnice-gstreamer.  So it should be safe to remove GStreamer 0.10 support unconditionally?
Comment 7 Tomas Hoger 2018-01-23 12:24:19 UTC 
That also solves my problem.  I only tried to be as non-invasive as possible, and I did not see an immediate need to drop gstreamer 0.10 support in Fedora.
Comment 8 Christian Fredrik Kalager Schaller 2018-01-23 12:32:02 UTC 
I think that should be fine, I don't know of any active projects using this. But I added Wim Taymans to the CC so he can correct me if I am wrong.
Comment 9 Tomas Hoger 2018-01-24 15:22:07 UTC 
Created attachment 1385645 [details]
Add conditional for building with(out) gst010 / GStreamer 0.10 support

Rewritten patch to use %bcond_with/%bcond_without and %if %{with gst010}.
Comment 10 Tomas Hoger 2018-01-24 15:25:06 UTC 
https://src.fedoraproject.org/rpms/libnice/pull-request/1

For the patch in comment 9.
Comment 13 Kamil Dudka 2018-01-29 15:46:12 UTC 
downstream commit:

https://src.fedoraproject.org/cgit/rpms/libnice.git/commit/?id=746455c9
Note You need to log in before you can comment on or make changes to this bug.