Bug 1538069

Summary: Review Request: nodejs-historic-readline - A JavaScript library extending the node readline module to save history to file
Product: [Fedora] Fedora Reporter: Timothée Floure <timothee.floure>
Component: Package ReviewAssignee: Robert-André Mauchin 🐧 <eclipseo>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: eclipseo, package-review
Target Milestone: ---Flags: eclipseo: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-02-01 16:34:58 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1538076    

Description Timothée Floure 2018-01-24 12:23:23 UTC 
Spec URL: https://fedorapeople.org/~fnux/pkg-reviews/nodejs-historic-readline.spec
SRPM URL: https://fedorapeople.org/~fnux/pkg-reviews/nodejs-historic-readline-1.0.8-2.fc26.src.rpm
Description: A JavaScript library extending the node readline module to save history to file.
Fedora Account System Username: fnux
Comment 1 Robert-André Mauchin 🐧 2018-01-24 17:24:34 UTC 
 - Use the macro %{?nodejs_find_provides_and_requires} in the header for EPEL compatibility. See https://fedoraproject.org/wiki/Packaging:Node.js?rd=Node.js/Packagers#Automatic_Requires_and_Provides

 - Use %nodejs_symlink_deps at the end of %install. See https://fedoraproject.org/wiki/Packaging:Node.js?rd=Node.js/Packagers#Symlinking_Dependencies.

 - Please consider asking upstream for a LICENSE file.


All ok otherwise:
 - Package builds in mock 
 - No RPMLint error
 - License ok
 - Latest version packaged
Comment 2 Timothée Floure 2018-01-28 13:15:42 UTC 
Updated specfile and SRPM addressing the two fisrt issues :
Spec URL: https://fedorapeople.org/~fnux/pkg-reviews/nodejs-historic-readline/nodejs-historic-readline.spec
SRPM URL: https://fedorapeople.org/~fnux/pkg-reviews/nodejs-historic-readline/nodejs-historic-readline-1.0.8-3.fc26.src.rpm

I also opened an issue [0] with upstream regarding the LICENSE file.

Thanks for the review !

[0] https://github.com/Centiq/historic-readline/issues/3
Comment 3 Robert-André Mauchin 🐧 2018-01-28 14:52:44 UTC 
All ok, package approved.
Comment 4 Gwyn Ciesla 2018-01-28 20:22:01 UTC 
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/nodejs-historic-readline