Spec URL: https://fedorapeople.org/~fnux/pkg-reviews/nodejs-historic-readline.spec SRPM URL: https://fedorapeople.org/~fnux/pkg-reviews/nodejs-historic-readline-1.0.8-2.fc26.src.rpm Description: A JavaScript library extending the node readline module to save history to file. Fedora Account System Username: fnux
- Use the macro %{?nodejs_find_provides_and_requires} in the header for EPEL compatibility. See https://fedoraproject.org/wiki/Packaging:Node.js?rd=Node.js/Packagers#Automatic_Requires_and_Provides - Use %nodejs_symlink_deps at the end of %install. See https://fedoraproject.org/wiki/Packaging:Node.js?rd=Node.js/Packagers#Symlinking_Dependencies. - Please consider asking upstream for a LICENSE file. All ok otherwise: - Package builds in mock - No RPMLint error - License ok - Latest version packaged
Updated specfile and SRPM addressing the two fisrt issues : Spec URL: https://fedorapeople.org/~fnux/pkg-reviews/nodejs-historic-readline/nodejs-historic-readline.spec SRPM URL: https://fedorapeople.org/~fnux/pkg-reviews/nodejs-historic-readline/nodejs-historic-readline-1.0.8-3.fc26.src.rpm I also opened an issue [0] with upstream regarding the LICENSE file. Thanks for the review ! [0] https://github.com/Centiq/historic-readline/issues/3
All ok, package approved.
(fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/nodejs-historic-readline