Bug 1538935

+++ This bug is an upstream to downstream clone. The original bug is: +++
+++   bug 1538925 +++
======================================================================

Created attachment 1386485 [details]
All logs from host (/tmp/imgbased.log, /var/log/*, sosreport)

Description of problem:
Upgrade failed when upgrade to rhvh-4.1-0.20180125.0
There is failed info during upgrade, and missing new build boot entry.

Version-Release number of selected component (if applicable):
From:
redhat-virtualization-host-4.1-20171101.0
To:
redhat-virtualization-host-4.1-20180125.0


How reproducible:
100%
regression bug

Steps to Reproduce:
1. Clean install redhat-virtualization-host-4.1-20171101.0
2. Reboot and login RHVH4.1, setup local repos, upgrade via:
   # yum update
3. Focus on the upgrade process
4. Reboot, focus on the boot entries

Actual results:
1. After step3, upgrade failed, there is failed info during upgrade:
# yum update
......
--> Running transaction check
---> Package redhat-virtualization-host-image-update.noarch 0:4.1-20180125.0.el7_4 will be obsoleting
---> Package redhat-virtualization-host-image-update-placeholder.noarch 0:4.1-7.0.el7 will be obsoleted
--> Finished Dependency Resolution

Dependencies Resolved

==================================================================================================================================================
 Package                                           Arch             Version                        Repository                                Size
==================================================================================================================================================
Installing:
 redhat-virtualization-host-image-update           noarch           4.1-20180125.0.el7_4           rhel-7-server-rhvh-4-beta-rpms           615 M
     replacing  redhat-virtualization-host-image-update-placeholder.noarch 4.1-7.0.el7

Transaction Summary
==================================================================================================================================================
Install  1 Package

Total download size: 615 M
Is this ok [y/d/N]: y
Downloading packages:
redhat-virtualization-host-image-update-latest.rpm                                                                         | 615 MB  00:00:08    
Running transaction check
Running transaction test
Transaction test succeeded
Running transaction
  Installing : redhat-virtualization-host-image-update-4.1-20180125.0.el7_4.noarch                                                            1/2
warning: %post(redhat-virtualization-host-image-update-4.1-20180125.0.el7_4.noarch) scriptlet failed, exit status 1
Non-fatal POSTIN scriptlet failure in rpm package redhat-virtualization-host-image-update-4.1-20180125.0.el7_4.noarch
  Erasing    : redhat-virtualization-host-image-update-placeholder-4.1-7.0.el7.noarch                                                         2/2
  Verifying  : redhat-virtualization-host-image-update-4.1-20180125.0.el7_4.noarch                                                            1/2
  Verifying  : redhat-virtualization-host-image-update-placeholder-4.1-7.0.el7.noarch                                                         2/2

Installed:
  redhat-virtualization-host-image-update.noarch 0:4.1-20180125.0.el7_4                                                                          

Replaced:
  redhat-virtualization-host-image-update-placeholder.noarch 0:4.1-7.0.el7                                                                        

Complete!

2. After step4, missing new build boot entry


Expected results:
1. After step3, should upgrade successful, there should be no failed/error info during upgrade.
2. After step4, there should be new build boot entry.

Additional info:
1. No such issue in the last build, so this is regression issue.
2. Some errors info in /tmp/imgbased.log:
Traceback (most recent call last):
  File "/usr/lib64/python2.7/runpy.py", line 162, in _run_module_as_main
    "__main__", fname, loader, pkg_name)
  File "/usr/lib64/python2.7/runpy.py", line 72, in _run_code
    exec code in run_globals
  File "/tmp/tmp.J55PpYHxLB/usr/lib/python2.7/site-packages/imgbased/__main__.py", line 53, in <module>
    CliApplication()
  File "/tmp/tmp.J55PpYHxLB/usr/lib/python2.7/site-packages/imgbased/__init__.py", line 82, in CliApplication
    app.hooks.emit("post-arg-parse", args)
  File "/tmp/tmp.J55PpYHxLB/usr/lib/python2.7/site-packages/imgbased/hooks.py", line 120, in emit
    cb(self.context, *args)
  File "/tmp/tmp.J55PpYHxLB/usr/lib/python2.7/site-packages/imgbased/plugins/update.py", line 56, in post_argparse
    base_lv, _ = LiveimgExtractor(app.imgbase).extract(args.FILENAME)
  File "/tmp/tmp.J55PpYHxLB/usr/lib/python2.7/site-packages/imgbased/plugins/update.py", line 118, in extract
    "%s" % size, nvr)
  File "/tmp/tmp.J55PpYHxLB/usr/lib/python2.7/site-packages/imgbased/plugins/update.py", line 99, in add_base_with_tree
    new_layer_lv = self.imgbase.add_layer(new_base)
  File "/tmp/tmp.J55PpYHxLB/usr/lib/python2.7/site-packages/imgbased/imgbase.py", line 191, in add_layer
    self.hooks.emit("new-layer-added", prev_lv, new_lv)
  File "/tmp/tmp.J55PpYHxLB/usr/lib/python2.7/site-packages/imgbased/hooks.py", line 120, in emit
    cb(self.context, *args)
  File "/tmp/tmp.J55PpYHxLB/usr/lib/python2.7/site-packages/imgbased/plugins/osupdater.py", line 123, in on_new_layer
    raise ConfigMigrationError()
imgbased.plugins.osupdater.ConfigMigrationError

(Originally by Huijuan Zhao)