Bug 1539329

Summary: geany.spec does not follow Fedora packaging guidelines
Product: [Fedora] Fedora Reporter: Van de Bugger <van.de.bugger>
Component: geanyAssignee: Dominic Hopf <dmaphy>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: unspecified    
Version: 27CC: dmaphy, egolov, josef, oliver, pingou, sergio
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: geany-1.32-3.fc27 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-01-30 18:07:45 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Proposed fix none

Description Van de Bugger 2018-01-27 23:57:37 UTC 
Created attachment 1387059 [details]
Proposed fix

Description of problem:

Fedora packaging guidelines <https://fedoraproject.org/wiki/Packaging:Guidelines>:

> BuildRequires based on pkg-config

> Fedora packages which use pkg-config to build against a library
> (e.g. 'foo') on which they depend, SHOULD express their build
> dependency correctly as pkgconfig(foo).

However, geany.spec contains:

> BuildRequires: desktop-file-utils, gettext, gtk3-devel, 
> glib2-devel, pango-devel, intltool

gtk3-devel and  glib2-devel requirements should be replaced with:

> BuildRequires: pkgconfig(gtk+-3.0)
> BuildRequires: pkgconfig(glib-2.0)

(not sure about pango-devel).


Version-Release number of selected component (if applicable):

Fedora 27, geany-1.32-1.fc27.src.rpm.


How reproducible:

Always.


Steps to Reproduce:
1. N/A

Actual results:
N/A

Expected results:
N/A

Additional info:
Comment 1 Fedora Update System 2018-01-28 15:10:54 UTC 
geany-1.32-3.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-9d8d296920
Comment 2 Fedora Update System 2018-01-28 23:05:54 UTC 
geany-1.32-3.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-9d8d296920
Comment 3 Fedora Update System 2018-01-30 18:07:45 UTC 
geany-1.32-3.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.
Comment 4 Sergio Basto 2018-03-22 18:24:12 UTC 
Hello , 

This report all may be applied to geany-plugins.spec !