Bug 1539329 - geany.spec does not follow Fedora packaging guidelines
Summary: geany.spec does not follow Fedora packaging guidelines
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: geany
Version: 27
Hardware: All
OS: Linux
unspecified
low
Target Milestone: ---
Assignee: Dominic Hopf
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-01-27 23:57 UTC by Van de Bugger
Modified: 2018-03-22 18:24 UTC (History)
6 users (show)

Fixed In Version: geany-1.32-3.fc27
Clone Of:
Environment:
Last Closed: 2018-01-30 18:07:45 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Proposed fix (557 bytes, patch)
2018-01-27 23:57 UTC, Van de Bugger
no flags Details | Diff

Description Van de Bugger 2018-01-27 23:57:37 UTC
Created attachment 1387059 [details]
Proposed fix

Description of problem:

Fedora packaging guidelines <https://fedoraproject.org/wiki/Packaging:Guidelines>:

> BuildRequires based on pkg-config

> Fedora packages which use pkg-config to build against a library
> (e.g. 'foo') on which they depend, SHOULD express their build
> dependency correctly as pkgconfig(foo).

However, geany.spec contains:

> BuildRequires: desktop-file-utils, gettext, gtk3-devel, 
> glib2-devel, pango-devel, intltool

gtk3-devel and  glib2-devel requirements should be replaced with:

> BuildRequires: pkgconfig(gtk+-3.0)
> BuildRequires: pkgconfig(glib-2.0)

(not sure about pango-devel).


Version-Release number of selected component (if applicable):

Fedora 27, geany-1.32-1.fc27.src.rpm.


How reproducible:

Always.


Steps to Reproduce:
1. N/A

Actual results:
N/A

Expected results:
N/A

Additional info:

Comment 1 Fedora Update System 2018-01-28 15:10:54 UTC
geany-1.32-3.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-9d8d296920

Comment 2 Fedora Update System 2018-01-28 23:05:54 UTC
geany-1.32-3.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-9d8d296920

Comment 3 Fedora Update System 2018-01-30 18:07:45 UTC
geany-1.32-3.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.

Comment 4 Sergio Basto 2018-03-22 18:24:12 UTC
Hello , 

This report all may be applied to geany-plugins.spec !


Note You need to log in before you can comment on or make changes to this bug.