Bug 1541095

Summary:	softhsm: Incomplete Fedora build flags injection
Product:	[Fedora] Fedora	Reporter:	Florian Weimer <fweimer>
Component:	softhsm	Assignee:	Paul Wouters <pwouters>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	nmavrogi, pwouters
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-02-02 08:12:26 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1539083

Description Florian Weimer 2018-02-01 16:39:09 UTC

In softhsm-2.3.0-2.fc28, /usr/bin/softhsm2-pk11install has not been linked with the Fedora linker flags:

+ gcc -lssl3 -lsmime3 -lnss3 -lnssutil3 -lplds4 -lplc4 -lnspr4 -lpthread -ldl -lpthread -lsoftokn3 -ldl -lz -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic softhsm2-pk11install.o -o softhsm2-pk11install

Among other things, -Wl,-z,relro is missing.

Comment 1 Nikos Mavrogiannopoulos 2018-02-02 07:42:55 UTC

I do not believe we need that program at all on F28. Smart cards are registered via p11-kit. I'll remove that app.

Comment 2 Florian Weimer 2018-02-02 08:18:01 UTC

(In reply to Nikos Mavrogiannopoulos from comment #1)
> I do not believe we need that program at all on F28. Smart cards are
> registered via p11-kit. I'll remove that app.

It's used by various packages.  We cannot remove it without adjusting some (build) dependencies.

Comment 4 Florian Weimer 2018-02-02 08:26:57 UTC

(In reply to Nikos Mavrogiannopoulos from comment #1)
> I do not believe we need that program at all on F28.

Ah, “that program” means softhsm2-pk11install.  Never mind my following comment.