Bug 1541095 - softhsm: Incomplete Fedora build flags injection
Summary: softhsm: Incomplete Fedora build flags injection
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: softhsm
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Paul Wouters
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: Fedora28BuildFlags
TreeView+ depends on / blocked
 
Reported: 2018-02-01 16:39 UTC by Florian Weimer
Modified: 2018-02-05 07:10 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2018-02-02 08:12:26 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1173577 0 unspecified CLOSED Load p11-kit tokens by default 2021-02-22 00:41:40 UTC

Description Florian Weimer 2018-02-01 16:39:09 UTC 
In softhsm-2.3.0-2.fc28, /usr/bin/softhsm2-pk11install has not been linked with the Fedora linker flags:

+ gcc -lssl3 -lsmime3 -lnss3 -lnssutil3 -lplds4 -lplc4 -lnspr4 -lpthread -ldl -lpthread -lsoftokn3 -ldl -lz -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic softhsm2-pk11install.o -o softhsm2-pk11install

Among other things, -Wl,-z,relro is missing.
Comment 1 Nikos Mavrogiannopoulos 2018-02-02 07:42:55 UTC 
I do not believe we need that program at all on F28. Smart cards are registered via p11-kit. I'll remove that app.
Comment 2 Florian Weimer 2018-02-02 08:18:01 UTC 
(In reply to Nikos Mavrogiannopoulos from comment #1)
> I do not believe we need that program at all on F28. Smart cards are
> registered via p11-kit. I'll remove that app.

It's used by various packages.  We cannot remove it without adjusting some (build) dependencies.
Comment 4 Florian Weimer 2018-02-02 08:26:57 UTC 
(In reply to Nikos Mavrogiannopoulos from comment #1)
> I do not believe we need that program at all on F28.

Ah, “that program” means softhsm2-pk11install.  Never mind my following comment.
Note You need to log in before you can comment on or make changes to this bug.