Bug 1542610

Summary:	Service Dialogs: Different behaviour of items wrt default values
Product:	Red Hat CloudForms Management Engine	Reporter:	Satoe Imaishi <simaishi>
Component:	UI - OPS	Assignee:	eclarizi
Status:	CLOSED CURRENTRELEASE	QA Contact:	Antonin Pagac <apagac>
Severity:	high	Docs Contact:
Priority:	high
Version:	5.9.0	CC:	apagac, brant.evans, cpelland, gmccullo, hkataria, kmorey, lavenel, mpovolny, obarenbo, smallamp
Target Milestone:	GA
Target Release:	5.9.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	5.9.0.21	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1540273	Environment:
Last Closed:	2018-03-06 15:16:47 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	CFME Core	Target Upstream Version:
Embargoed:
Bug Depends On:	1540273
Bug Blocks:

Comment 2 CFME Bot 2018-02-06 16:29:08 UTC

New commit detected on ManageIQ/manageiq-ui-classic/gaprindashvili:
https://github.com/ManageIQ/manageiq-ui-classic/commit/962bc8144a93352fb7c7d112d45b80a6a87b2092

commit 962bc8144a93352fb7c7d112d45b80a6a87b2092
Author:     Dan Clarizio <dclarizi>
AuthorDate: Mon Feb 5 13:18:56 2018 -0800
Commit:     Satoe Imaishi <simaishi>
CommitDate: Tue Feb 6 11:20:29 2018 -0500

    Merge pull request #3371 from eclarizio/BZ1540273
    
    Fix for different behavior of items in regards to default values on dialog sample page
    (cherry picked from commit 4bddbcf4788e76ee6b44fc66c1940f50f160450a)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1542610

 app/views/miq_ae_customization/_dialog_sample.html.haml | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

Comment 3 CFME Bot 2018-02-06 23:02:00 UTC

New commit detected on ManageIQ/manageiq/gaprindashvili:
https://github.com/ManageIQ/manageiq/commit/f2b57b7b5be9fb9d2e967b166ce8aa02bda74b52

commit f2b57b7b5be9fb9d2e967b166ce8aa02bda74b52
Author:     Greg McCullough <gmccullo>
AuthorDate: Tue Feb 6 13:14:38 2018 -0500
Commit:     Satoe Imaishi <simaishi>
CommitDate: Tue Feb 6 17:56:30 2018 -0500

    Merge pull request #16955 from eclarizio/BZ1540273
    
    Fix for differing behavior in DialogFieldTagControl multi/single drop downs
    (cherry picked from commit e07ecd0eb7e23bcefd8838bf9ace0abf0817ee21)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1542610

 app/models/dialog_field_serializer.rb       |  5 ++++-
 spec/models/dialog_field_serializer_spec.rb | 14 ++++++++++----
 2 files changed, 14 insertions(+), 5 deletions(-)

Comment 4 Antonin Pagac 2018-02-15 10:15:55 UTC

With 5.9.0.21:

Text Box: works

Text Area: works

Check Box: works

Dropdown: doesn't work in SUI, bz 1531316

Radio Button: works

Datepicker: 
 - no "default value" field, bz 1541992
 - given values are NOT shown on edit page or sample page
 - given values are shown on ordering page in OPS UI but NOT in SUI

Timepicker:
 - no "default value" field, bz 1541992
 - given values are NOT shown on edit page or sample page
 - given values are shown on ordering page in OPS UI
 - in SUI, only time shows the default value, there is no date shown
 - the missing time issue is fixed

Tag Control:
 - no "default value" field, bz 1541999
 - with "Department" category and Single value "No" it works everywhere BUT the edit screen, where it still shows single value style
 - with "Environment" category and Single value "No" it shows single value style everywhere. When saving and editing again, I can see the Single value has changed to "Yes" by itself. We should not let the user choose a non-working option

There still are things to be fixed from my point of view. Don't hesitate to contact me if something seems unclear.