Bug 1542850 (CVE-2017-10689)

Summary: CVE-2017-10689 puppet: Unpacking of tarballs in tar/mini.rb can create files with insecure permissions
Product: [Other] Security Response Reporter: Sam Fowler <sfowler>
Component: vulnerabilityAssignee: Red Hat Product Security <security-response-team>
Status: CLOSED WONTFIX QA Contact:
Severity: low Docs Contact:
Priority: low    
Version: unspecifiedCC: apevec, athmanem, bcourt, bkearney, chrisw, jjoyce, jmatthew, jschluet, kbasil, lhh, lpeer, lutter, markmc, mburns, mmagr, mmccune, mrike, ohadlevy, rbryant, rchan, sclewis, slinaber, srevivo, s, tdecacqu, terje.rosten, tjay, tsanders
Target Milestone: ---Keywords: Security
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: puppet 4.10.10, puppet 5.3.4 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-02-15 05:19:37 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1542852, 1543950, 1543951    
Bug Blocks: 1542832    

Description Sam Fowler 2018-02-07 07:34:50 UTC
In puppet before versions 4.10.10 and 5.3.4, when unpacking tarballs with minitar in lib/puppet/module_tool/tar/mini.rb, files are unpacked with the same permissions as in the tarball allowing for files with unsafe permissions.


Upstream Advisory:

https://puppet.com/security/cve/CVE-2017-10689


Upstream Issue:

https://tickets.puppetlabs.com/browse/PUP-7866


Upstream Commit:

https://github.com/puppetlabs/puppet/commit/17d9e02da3882e44c1876e2805cf9708481715ee

Comment 1 Sam Fowler 2018-02-07 07:35:17 UTC
Created puppet tracking bugs for this issue:

Affects: fedora-all [bug 1542852]

Comment 3 Kurt Seifried 2018-02-09 16:10:30 UTC
Please note that Puppet 3.x has mini.rb with the exact same code as 4.x, so it appears to be vulnerable, additionally the patch at https://github.com/puppetlabs/puppet/commit/17d9e02da3882e44c1876e2805cf9708481715ee should fix it.

Comment 6 Andrej Nemec 2018-05-14 13:56:15 UTC
Statement:

Red Hat Product Security has rated this issue as having security impact of Low. This issue affects the versions of puppet as shipped with:
* Red Hat Satellite 6.  A future update may address this issue. 
* Red Hat OpenStack Platform versions 6-12.  Although the affected code is present in shipped packages, the affected code can only be exploited by deploying unsupported custom puppet modules. This issue is not currently planned to be addressed in future updates. 

For additional information, refer to the Issue Severity Classification: https://access.redhat.com/security/updates/classification/.

Comment 7 errata-xmlrpc 2018-10-16 15:20:19 UTC
This issue has been addressed in the following products:

  Red Hat Satellite 6.4 for RHEL 7

Via RHSA-2018:2927 https://access.redhat.com/errata/RHSA-2018:2927