Bug 1543911

Summary:	libffdao: Build flags injection is only partially effective
Product:	[Fedora] Fedora	Reporter:	Florian Weimer <fweimer>
Component:	libffado	Assignee:	Brendan Jones <brendan.jones.it>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	brendan.jones.it, nphilipp, oget.fedora
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-02-10 19:54:17 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1539083

Comment 1 Florian Weimer 2018-02-09 14:47:41 UTC

Sorry, I hit Enter by accident.

libffado-2.4.0-4.fc28 does not build all binaries with full hardening flags.  /usr/bin/ffado-bridgeco-downloader, /usr/bin/ffado-dbus-server, /usr/bin/ffado-dice-firmware, /usr/bin/ffado-fireworks-downloader, /usr/bin/ffado-set-nickname do not use the standard linker flags (LDFLAGS) from redhat-rpm-config package.  I tried to fix this in libffado-2.4.0-4.fc28, but apparently, makefile changes are needed, too.

More information about RPM macros to set CFLAGS and LDFLAGS is available here:
https://src.fedoraproject.org/rpms/redhat-rpm-config/blob/master/f/buildflags.md

Comment 2 Orcan Ogetbil 2018-02-10 01:39:45 UTC

You forgot to put the "export LDFLAGS=..." into the %install section.

Whenever these flags differ between %build and %install, scons triggers a rebuild of the affected files in %install. 

So these files are built twice. Once in %build and once in %install. And the second builds, which have empty LDFLAGS, are being installed.

Comment 3 Orcan Ogetbil 2018-02-10 19:54:17 UTC

fixed in rawhide