Bug 1543911 - libffdao: Build flags injection is only partially effective
Summary: libffdao: Build flags injection is only partially effective
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: libffado
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Brendan Jones
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: Fedora28BuildFlags
TreeView+ depends on / blocked
 
Reported: 2018-02-09 14:43 UTC by Florian Weimer
Modified: 2018-02-10 19:54 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2018-02-10 19:54:17 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)

Comment 1 Florian Weimer 2018-02-09 14:47:41 UTC 
Sorry, I hit Enter by accident.

libffado-2.4.0-4.fc28 does not build all binaries with full hardening flags.  /usr/bin/ffado-bridgeco-downloader, /usr/bin/ffado-dbus-server, /usr/bin/ffado-dice-firmware, /usr/bin/ffado-fireworks-downloader, /usr/bin/ffado-set-nickname do not use the standard linker flags (LDFLAGS) from redhat-rpm-config package.  I tried to fix this in libffado-2.4.0-4.fc28, but apparently, makefile changes are needed, too.

More information about RPM macros to set CFLAGS and LDFLAGS is available here:
https://src.fedoraproject.org/rpms/redhat-rpm-config/blob/master/f/buildflags.md
Comment 2 Orcan Ogetbil 2018-02-10 01:39:45 UTC 
You forgot to put the "export LDFLAGS=..." into the %install section.

Whenever these flags differ between %build and %install, scons triggers a rebuild of the affected files in %install. 

So these files are built twice. Once in %build and once in %install. And the second builds, which have empty LDFLAGS, are being installed.
Comment 3 Orcan Ogetbil 2018-02-10 19:54:17 UTC 
fixed in rawhide
Note You need to log in before you can comment on or make changes to this bug.