Bug 1544151

Summary:	Review Request: python-idna-ssl - Patch ssl.match_hostname for Unicode(idna) domains support
Product:	[Fedora] Fedora	Reporter:	Igor Gnatenko <ignatenko>
Component:	Package Review	Assignee:	Neal Gompa <ngompa13>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	ngompa13, package-review
Target Milestone:	---	Flags:	ngompa13: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-02-11 17:35:54 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Igor Gnatenko 2018-02-10 19:39:25 UTC

Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/python-idna-ssl.spec
SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/python-idna-ssl-1.0.0-1.fc28.src.rpm
Description: Patch ssl.match_hostname for Unicode(idna) domains support.
Fedora Account System Username: ignatenkobrain

Comment 1 Neal Gompa 2018-02-10 19:41:22 UTC

Taking this review.

Comment 2 Neal Gompa 2018-02-10 19:48:53 UTC

Review notes:

[x] Package is named appropriately
[x] Package follows Python packaging guidelines
[x] Package follows Fedora packaging guidelines
[x] Package builds and installs correctly

[!] Missing %python_provide macro. Please fix on import.

PACKAGE APPROVED.

Comment 3 Gwyn Ciesla 2018-02-11 17:15:45 UTC

(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-idna-ssl