Bug 1544151 - Review Request: python-idna-ssl - Patch ssl.match_hostname for Unicode(idna) domains support
Summary: Review Request: python-idna-ssl - Patch ssl.match_hostname for Unicode(idna) ...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-02-10 19:39 UTC by Igor Gnatenko
Modified: 2018-02-11 17:35 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2018-02-11 17:35:54 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+


Attachments (Terms of Use)

Description Igor Gnatenko 2018-02-10 19:39:25 UTC
Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/python-idna-ssl.spec
SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/python-idna-ssl-1.0.0-1.fc28.src.rpm
Description: Patch ssl.match_hostname for Unicode(idna) domains support.
Fedora Account System Username: ignatenkobrain

Comment 1 Neal Gompa 2018-02-10 19:41:22 UTC
Taking this review.

Comment 2 Neal Gompa 2018-02-10 19:48:53 UTC
Review notes:

[x] Package is named appropriately
[x] Package follows Python packaging guidelines
[x] Package follows Fedora packaging guidelines
[x] Package builds and installs correctly

[!] Missing %python_provide macro. Please fix on import.

PACKAGE APPROVED.

Comment 3 Gwyn Ciesla 2018-02-11 17:15:45 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-idna-ssl


Note You need to log in before you can comment on or make changes to this bug.