Bug 1545173
| Summary: | dwz is using arch-dependent BuildRequires | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Igor Gnatenko <ignatenko> |
| Component: | dwz | Assignee: | Jakub Jelinek <jakub> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | high | ||
| Version: | 28 | CC: | jakub, mjw |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | dwz-0.12-9.fc29 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-07-20 11:34:09 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1545161 | ||
This bug appears to have been reported against 'rawhide' during the Fedora 28 development cycle. Changing version to '28'. ping? Here is a simple patch to do it.
But I don't know how to request commit access to the rpms/dwz project to push it. Is there some way to request group access on src.fedoraproject.org for a specific srpm?
diff --git a/dwz.spec b/dwz.spec
index fdbd42b..985481e 100644
--- a/dwz.spec
+++ b/dwz.spec
@@ -1,14 +1,14 @@
Summary: DWARF optimization and duplicate removal tool
Name: dwz
Version: 0.12
-Release: 7%{?dist}
+Release: 8%{?dist}
License: GPLv2+ and GPLv3+
Group: Development/Tools
# git archive --format=tar --remote=git://sourceware.org/git/dwz.git \
# --prefix=%{name}-%{version}/ %{name}-%{version} \
# | bzip2 -9 > %{name}-%{version}.tar.bz2
Source: %{name}-%{version}.tar.bz2
-BuildRequires: elfutils-libelf-devel%{?_isa}
+BuildRequires: elfutils-libelf-devel
%description
The dwz package contains a program that attempts to optimize DWARF
@@ -23,7 +23,7 @@ and using DW_TAG_imported_unit to import it into each CU that needs it.
%setup -q
%build
-make %{?_smp_mflags} CFLAGS='%{optflags}' LDFLAGS='%{build_ldflags}' \
+make %{?_smp_mflags} CFLAGS="$RPM_OPT_FLAGS" LDFLAGS="$RPM_LD_FLAGS" \
prefix=%{_prefix} mandir=%{_mandir} bindir=%{_bindir}
%install
@@ -38,6 +38,11 @@ make DESTDIR=%{buildroot} prefix=%{_prefix} mandir=%{_mandir} bindir=%{_bindir}
%{_mandir}/man1/dwz.1*
%changelog
+* Mon Jul 02 2018 Mark Wielaard <mjw> - 0.12-8
+- Remove %%{?_isa} from BuildRequires (#1545173)
+- Use RPM_OPT_FLAGS and RPM_LD_FLAGS instead of
+ %%{optflags} and %%{build_ldflags}.
+
* Fri Feb 23 2018 Florian Weimer <fweimer> - 0.12-7
- Use LDFLAGS from redhat-rpm-config
Marek pushed a fix. The needinfo request[s] on this closed bug have been removed as they have been unresolved for 1000 days |
dwz is using %{?_isa} in BuildRequires which is prohibited by Packaging Guidelines: https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRequires_and_.25.7B_isa.7D. Please fix it ASAP.