Bug 1545210
| Summary: | tpm2-abrmd is using arch-dependent BuildRequires | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Igor Gnatenko <ignatenko> |
| Component: | tpm2-abrmd | Assignee: | Yunying Sun <yunying.sun> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | high | ||
| Version: | 28 | CC: | fmartine, javierm, yunying.sun |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-02-24 05:08:58 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1545161 | ||
This bug appears to have been reported against 'rawhide' during the Fedora 28 development cycle. Changing version to '28'. Javier fixed this with https://src.fedoraproject.org/rpms/tpm2-abrmd/pull-request/4. Javier is testing this package on non-IA platforms so change needinfo to Javier. (In reply to Yunying Sun from comment #2) > Javier fixed this with > https://src.fedoraproject.org/rpms/tpm2-abrmd/pull-request/4. Your comment is inaccurate, it should use `%%{_isa}` instead of `%{_isa}` to escape macro. (In reply to Igor Gnatenko from comment #4) > (In reply to Yunying Sun from comment #2) > > Javier fixed this with > > https://src.fedoraproject.org/rpms/tpm2-abrmd/pull-request/4. > > Your comment is inaccurate, it should use `%%{_isa}` instead of `%{_isa}` to > escape macro. Hmm, right. I guess the side effect is that the macro would be expanded... Can I fix it even if the change is already in rawhide or it's too late? (In reply to Javier Martinez Canillas from comment #5) > (In reply to Igor Gnatenko from comment #4) > > (In reply to Yunying Sun from comment #2) > > > Javier fixed this with > > > https://src.fedoraproject.org/rpms/tpm2-abrmd/pull-request/4. > > > > Your comment is inaccurate, it should use `%%{_isa}` instead of `%{_isa}` to > > escape macro. > > Hmm, right. I guess the side effect is that the macro would be expanded... > > Can I fix it even if the change is already in rawhide or it's too late? Feel free to ;) (In reply to Igor Gnatenko from comment #6) > (In reply to Javier Martinez Canillas from comment #5) > > (In reply to Igor Gnatenko from comment #4) > > > (In reply to Yunying Sun from comment #2) > > > > Javier fixed this with > > > > https://src.fedoraproject.org/rpms/tpm2-abrmd/pull-request/4. > > > > > > Your comment is inaccurate, it should use `%%{_isa}` instead of `%{_isa}` to > > > escape macro. > > > > Hmm, right. I guess the side effect is that the macro would be expanded... > > > > Can I fix it even if the change is already in rawhide or it's too late? > > Feel free to ;) Done, thanks a lot for pointing it out: https://src.fedoraproject.org/rpms/tpm2-abrmd/c/ed4ecb5febe0f589d3a207242dc2c24d10a70176 I should remember to always run rpmlint as a part of my workflow... Fixes for the arch-dependent BuildRequires issue and the macro escape issue in comment landed on master & f28. Suppose this issue can be closed. |
tpm2-abrmd is using %{?_isa} in BuildRequires which is prohibited by Packaging Guidelines: https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRequires_and_.25.7B_isa.7D. Please fix it ASAP.