Bug 1545210 - tpm2-abrmd is using arch-dependent BuildRequires
Summary: tpm2-abrmd is using arch-dependent BuildRequires
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: tpm2-abrmd
Version: 28
Hardware: Unspecified
OS: Unspecified
high
unspecified
Target Milestone: ---
Assignee: Yunying Sun
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1545161
TreeView+ depends on / blocked
 
Reported: 2018-02-14 12:06 UTC by Igor Gnatenko
Modified: 2018-02-24 05:08 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2018-02-24 05:08:58 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Igor Gnatenko 2018-02-14 12:06:33 UTC
tpm2-abrmd is using %{?_isa} in BuildRequires which is prohibited by Packaging Guidelines: https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRequires_and_.25.7B_isa.7D. Please fix it ASAP.

Comment 1 Fedora End Of Life 2018-02-20 15:31:55 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 28 development cycle.
Changing version to '28'.

Comment 2 Yunying Sun 2018-02-22 06:27:11 UTC
Javier fixed this with https://src.fedoraproject.org/rpms/tpm2-abrmd/pull-request/4.

Comment 3 Yunying Sun 2018-02-22 06:50:19 UTC
Javier is testing this package on non-IA platforms so change needinfo to Javier.

Comment 4 Igor Gnatenko 2018-02-22 07:14:39 UTC
(In reply to Yunying Sun from comment #2)
> Javier fixed this with
> https://src.fedoraproject.org/rpms/tpm2-abrmd/pull-request/4.

Your comment is inaccurate, it should use `%%{_isa}` instead of `%{_isa}` to escape macro.

Comment 5 Javier Martinez Canillas 2018-02-22 07:20:16 UTC
(In reply to Igor Gnatenko from comment #4)
> (In reply to Yunying Sun from comment #2)
> > Javier fixed this with
> > https://src.fedoraproject.org/rpms/tpm2-abrmd/pull-request/4.
> 
> Your comment is inaccurate, it should use `%%{_isa}` instead of `%{_isa}` to
> escape macro.

Hmm, right. I guess the side effect is that the macro would be expanded...

Can I fix it even if the change is already in rawhide or it's too late?

Comment 6 Igor Gnatenko 2018-02-22 07:23:59 UTC
(In reply to Javier Martinez Canillas from comment #5)
> (In reply to Igor Gnatenko from comment #4)
> > (In reply to Yunying Sun from comment #2)
> > > Javier fixed this with
> > > https://src.fedoraproject.org/rpms/tpm2-abrmd/pull-request/4.
> > 
> > Your comment is inaccurate, it should use `%%{_isa}` instead of `%{_isa}` to
> > escape macro.
> 
> Hmm, right. I guess the side effect is that the macro would be expanded...
> 
> Can I fix it even if the change is already in rawhide or it's too late?

Feel free to ;)

Comment 7 Javier Martinez Canillas 2018-02-22 07:42:48 UTC
(In reply to Igor Gnatenko from comment #6)
> (In reply to Javier Martinez Canillas from comment #5)
> > (In reply to Igor Gnatenko from comment #4)
> > > (In reply to Yunying Sun from comment #2)
> > > > Javier fixed this with
> > > > https://src.fedoraproject.org/rpms/tpm2-abrmd/pull-request/4.
> > > 
> > > Your comment is inaccurate, it should use `%%{_isa}` instead of `%{_isa}` to
> > > escape macro.
> > 
> > Hmm, right. I guess the side effect is that the macro would be expanded...
> > 
> > Can I fix it even if the change is already in rawhide or it's too late?
> 
> Feel free to ;)

Done, thanks a lot for pointing it out:

https://src.fedoraproject.org/rpms/tpm2-abrmd/c/ed4ecb5febe0f589d3a207242dc2c24d10a70176

I should remember to always run rpmlint as a part of my workflow...

Comment 8 Yunying Sun 2018-02-24 05:08:58 UTC
Fixes for the arch-dependent BuildRequires issue and the macro escape issue in comment landed on master & f28. Suppose this issue can be closed.


Note You need to log in before you can comment on or make changes to this bug.