Bug 1546993

Summary:	Shebang mangling informs about whitespace only chnages
Product:	[Fedora] Fedora	Reporter:	Miro Hrončok <mhroncok>
Component:	redhat-rpm-config	Assignee:	Miro Hrončok <mhroncok>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	ajax, ffesti, fweimer, ignatenko, john.j5live, jonathan, plautrba, pmatilai, praiskup
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	redhat-rpm-config-100-1.fc28	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-03-19 21:08:35 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Miro Hrončok 2018-02-20 10:03:21 UTC

mangling shebang in /usr/sbin/semanage from #! /usr/bin/python3 -Es to #!/usr/bin/python3 -Es 



The space might be weird, but it's harmless. Mangling it harmless as well. Not mangling it is also harmless. The information in the log is however might be disturbing.

I will propose a change that will remove the log line (and also will or will not mangle whitespace only, whatever will be easier).

Comment 1 Panu Matilainen 2018-02-20 10:16:09 UTC

All modifications bear some risk of breaking something and/or other unexpected behavior so any modification need to be logged.

Me thinks scripts should only touch files if they absolutely must, cosmetics are better left for humans.

Comment 2 Miro Hrončok 2018-02-20 10:37:15 UTC

https://src.fedoraproject.org/rpms/redhat-rpm-config/pull-request/21

Comment 3 Miro Hrončok 2018-02-20 10:37:46 UTC

Yep, the change disables the mangling if only whitespace would be changed.

Comment 4 Panu Matilainen 2018-02-22 09:48:17 UTC

On a related note, bug 1547805 is an excellent example why all modifications need to be logged...