Bug 1546993 - Shebang mangling informs about whitespace only chnages
Summary: Shebang mangling informs about whitespace only chnages
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: redhat-rpm-config
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Miro Hrončok
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-02-20 10:03 UTC by Miro Hrončok
Modified: 2018-03-19 21:08 UTC (History)
9 users (show)

Fixed In Version: redhat-rpm-config-100-1.fc28
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-03-19 21:08:35 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1547805 0 unspecified CLOSED rpm generate bogus requirements on F28+ 2021-02-22 00:41:40 UTC

Internal Links: 1547805

Description Miro Hrončok 2018-02-20 10:03:21 UTC
mangling shebang in /usr/sbin/semanage from #! /usr/bin/python3 -Es to #!/usr/bin/python3 -Es 



The space might be weird, but it's harmless. Mangling it harmless as well. Not mangling it is also harmless. The information in the log is however might be disturbing.

I will propose a change that will remove the log line (and also will or will not mangle whitespace only, whatever will be easier).

Comment 1 Panu Matilainen 2018-02-20 10:16:09 UTC
All modifications bear some risk of breaking something and/or other unexpected behavior so any modification need to be logged.

Me thinks scripts should only touch files if they absolutely must, cosmetics are better left for humans.

Comment 3 Miro Hrončok 2018-02-20 10:37:46 UTC
Yep, the change disables the mangling if only whitespace would be changed.

Comment 4 Panu Matilainen 2018-02-22 09:48:17 UTC
On a related note, bug 1547805 is an excellent example why all modifications need to be logged...


Note You need to log in before you can comment on or make changes to this bug.