Bug 154713
| Summary: | 5 * undefined C code | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | David Binderman <dcb314> |
| Component: | HelixPlayer | Assignee: | John (J5) Palmieri <johnp> |
| Status: | CLOSED UPSTREAM | QA Contact: | |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | jkeck |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2005-04-20 21:07:19 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
This should be filed with the Helix Player developers. >This should be filed with the Helix Player developers.
I tried to do this, but the helixplayer homepage wouldn't let me.
Maybe you would have better luck.
I think it would be pretty easy to brew up a suggested patch to
fix these compiler warnings, while we wait for the helix player pages
to sort themselves out.
Suggest carry patch forward into new versions for Fedora.
Feel free to submit a patch. I'm busy with crashers and the like for FC4 so this is low in my queue. Are you sure this codepath is even used or is just cruft laying around that developers haven't taken out yet? I'll file the bug upstream. >Are you sure this codepath is even used I have no idea. I just compiled the code. >I'll file the bug upstream. Thanks |
From Bugzilla Helper: User-Agent: Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.7.2) Gecko/20040804 Netscape/7.2 (ax) Description of problem: I just tried to compile HelixPlayer-1.0.3-4 from Redhat Fedora Core development tree The compiler said 1. hxaudses.cpp:1779: warning: operation on 'pShortBuf' may be undefined The source code is *pOutUCharBuf++ = (UCHAR) ( ((LONG32) ((*pShortBuf++ + 32768L) >> 8) + (LONG32) ((*pShortBuf++ + 32768L) >> 8))/2 ); Clearly undefined code. Suggest code rework. 2. hxaudses.cpp:1787: warning: operation on 'pShortBuf' may be undefined Duplicate. 3. pxjpgrnd.cpp:1145: warning: operation on 'pPix' may be undefined The source code is *pPix++ = (*pPix & 0x00FFFFFF) | ulMediaAlpha; More undefined code. Suggest code rework. 4. pxjpgrnd.cpp:1195: warning: operation on 'pPix' may be undefined pxjpgrnd.cpp:1200: warning: operation on 'pPix' may be undefined Duplicates I just tried to compile HelixPlayer-1.0.3-4 from Redhat Fedora Core development tree The compiler said 1. hxaudses.cpp:1779: warning: operation on 'pShortBuf' may be undefined The source code is *pOutUCharBuf++ = (UCHAR) ( ((LONG32) ((*pShortBuf++ + 32768L) >> 8) + (LONG32) ((*pShortBuf++ + 32768L) >> 8))/2 ); Clearly undefined code. Suggest code rework. 2. hxaudses.cpp:1787: warning: operation on 'pShortBuf' may be undefined Duplicate. 3. pxjpgrnd.cpp:1145: warning: operation on 'pPix' may be undefined The source code is *pPix++ = (*pPix & 0x00FFFFFF) | ulMediaAlpha; More undefined code. Suggest code rework. 4. pxjpgrnd.cpp:1195: warning: operation on 'pPix' may be undefined pxjpgrnd.cpp:1200: warning: operation on 'pPix' may be undefined Duplicates Version-Release number of selected component (if applicable): HelixPlayer-1.0.3-4 How reproducible: Always Steps to Reproduce: 1. compile the code with flag -Wall 2. 3. Additional info: