Bug 1547453

Summary:	create one VDO volume when encryption & dedupe enabled on few or all the bricks on the same device
Product:	[oVirt] cockpit-ovirt	Reporter:	SATHEESARAN <sasundar>
Component:	Gdeploy	Assignee:	Parth Dhanjal <dparth>
Status:	CLOSED CURRENTRELEASE	QA Contact:	SATHEESARAN <sasundar>
Severity:	high	Docs Contact:
Priority:	high
Version:	0.11.7	CC:	bugs, rhs-bugs, sabose
Target Milestone:	ovirt-4.2.2	Flags:	sasundar: ovirt-4.2? sabose: exception? sasundar: planning_ack? rule-engine: devel_ack+ sasundar: testing_ack+
Target Release:	0.11.16
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	cockpit-ovirt-0.11.16-1	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1547450	Environment:
Last Closed:	2018-04-27 07:22:28 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Gluster	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1547450

Description SATHEESARAN 2018-02-21 11:12:27 UTC

+++ This bug was initially created as a clone of Bug #1547450 +++

Description of problem:
-----------------------
User can enable dedupe & compression on select few or all the bricks on the same device. Currently the dedupe & compression will be enabled on all the bricks, that are created on the same device.

But when the user has chosen to enable dedupe & compression on 2 bricks from the same device, 2 different VDO volumes are created.

When the user has chosen to enable dedupe & compression on 3 bricks ( engine, vmstore, data ) from the same device, 3 different VDO volumes are created.

Version-Release number of selected component (if applicable):
--------------------------------------------------------------

How reproducible:
-----------------
Always

Steps to Reproduce:
-------------------
1. Start RHHI installation from cockpit using 'Hosted Engine with Gluster' 
2. On the bricks tab (4th tab), select 'Enable Dedupe & Compression' on all the 3 bricks
3. Observe the generated gdeploy config file

Actual results:
---------------
1. Generated gdeploy config file has sections to create 3 different VDO volumes
2. Name of VDO volume is not generic

Expected results:
-----------------
1. Generated gdeploy config file should have sections to create only one VDO volume
2. Name of the VDO volume should be generic corresponding to the device (e.g)vdovolume_sdb

Comment 1 SATHEESARAN 2018-02-21 11:16:17 UTC

Additional info:
----------------
Following is the snip of config file with dedupe & compression enabled on all the 3 bricks (ie.) engine, data, vmstore

[vdo]
action=create
devices=sdb,sdb,sdb
names=engine,data,vmstore
logicalsize=400,2000,2000

Following is the snip of config file with dedupe & compression enabled on all the 2 bricks (ie.) engine, data

[vdo]
action=create
devices=sdb,sdb
names=engine,data
logicalsize=400,2000

Irrespective of dedupe and compression enabled 1 or 2 or 3 bricks, the expected conf file should be:

[vdo]
action=create
devices=sdb
names=vdovol_sdb
logicalsize=<size>

Comment 2 SATHEESARAN 2018-04-25 10:26:47 UTC

Tested with cockpit-ovirt-dashboard-0.11.22
There is only VDO volume created for all the bricks.

Comment 3 Sandro Bonazzola 2018-04-27 07:22:28 UTC

This bugzilla is included in oVirt 4.2.2 release, published on March 28th 2018.

Since the problem described in this bug report should be
resolved in oVirt 4.2.2 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.