Bug 1547696

Summary: Review Request: nodejs-conventional-changelog-preset-loader - Configuration preset loader for conventional-changelog
Product: [Fedora] Fedora Reporter: Jared Smith <jsmith.fedora>
Component: Package ReviewAssignee: Robert-André Mauchin 🐧 <eclipseo>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: eclipseo, package-review
Target Milestone: ---Flags: eclipseo: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-02-26 11:00:52 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1547684    
Bug Blocks: 956806, 1547733    

Description Jared Smith 2018-02-21 18:21:46 UTC 
Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-conventional-changelog-preset-loader/nodejs-conventional-changelog-preset-loader.spec
SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-conventional-changelog-preset-loader/nodejs-conventional-changelog-preset-loader-1.1.5-1.fc28.src.rpm
Description: Configuration preset loader for conventional-changelog
Fedora Account System Username: jsmith
Comment 1 Robert-André Mauchin 🐧 2018-02-22 11:45:05 UTC 
 - Tests error:

+ /usr/bin/mocha -R spec
BUILDSTDERR: module.js:540
BUILDSTDERR:     throw err;
BUILDSTDERR:     ^
BUILDSTDERR: Error: Cannot find module 'chai'

   Add:

BuildRequires:	npm(chai)




 - License ok
 - Latest version packaged
 - Builds in mock
 - No rpmlint errors

Package approved. Just don't forget to fix the error above before import.
Comment 2 Jared Smith 2018-02-23 13:54:21 UTC 
Repo requested at https://pagure.io/releng/fedora-scm-requests/issue/4711.
Comment 3 Gwyn Ciesla 2018-02-23 14:19:03 UTC 
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/nodejs-conventional-changelog-preset-loader
Comment 4 Jared Smith 2018-02-26 11:00:52 UTC 
Packaged in Rawhide, closing this issue