Bug 1547733 - Review Request: nodejs-conventional-recommended-bump - Get a recommended version bump based on conventional commits
Summary: Review Request: nodejs-conventional-recommended-bump - Get a recommended vers...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1547696
Blocks: nodejs-reviews
TreeView+ depends on / blocked
 
Reported: 2018-02-21 20:20 UTC by Jared Smith
Modified: 2018-03-31 20:58 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2018-03-31 20:58:57 UTC
Type: ---
Embargoed:
eclipseo: fedora-review+

Attachments (Terms of Use)

Description Jared Smith 2018-02-21 20:20:06 UTC 
Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-conventional-recommended-bump/nodejs-conventional-recommended-bump.spec
SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-conventional-recommended-bump/nodejs-conventional-recommended-bump-2.0.5-1.fc28.src.rpm
Description: Get a recommended version bump based on conventional commits
Fedora Account System Username: jsmith
Comment 1 Robert-André Mauchin 🐧 2018-02-22 11:54:49 UTC 
 - Some dependencies are missing:

DEBUG util.py:482:  BUILDSTDERR: No matching package to install: 'npm(git-raw-commits)'
DEBUG util.py:482:  BUILDSTDERR: No matching package to install: 'npm(git-semver-tags)'
DEBUG util.py:482:  BUILDSTDERR: Not all dependencies satisfied
DEBUG util.py:482:  BUILDSTDERR: Error: Some packages could not be found.
Comment 2 Jared Smith 2018-03-27 16:37:05 UTC 
These dependencies are now in rawhide -- mind finishing the review?
Comment 3 Robert-André Mauchin 🐧 2018-03-27 17:38:04 UTC 
Tests are failing. See the logs: https://koji.fedoraproject.org/koji/taskinfo?taskID=26005553
Comment 4 Jared Smith 2018-03-29 14:23:15 UTC 
Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-conventional-recommended-bump/nodejs-conventional-recommended-bump.spec
SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-conventional-recommended-bump/nodejs-conventional-recommended-bump-2.0.8-1.fc29.src.rpm

Successful scratch build in Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=26042058
Comment 5 Robert-André Mauchin 🐧 2018-03-29 15:43:38 UTC 
DEBUG util.py:482:  BUILDSTDERR: Error: 
DEBUG util.py:482:  BUILDSTDERR:  Problem: conflicting requests
DEBUG util.py:482:  BUILDSTDERR:   - nothing provides (npm(conventional-changelog-preset-loader) >= 1.1.8 with npm(conventional-changelog-preset-loader) < 2) needed by nodejs-conventional-recommended-bump-2.0.8-1.fc29.noarch


npm(conventional-changelog-preset-loader) is 1.1.5 in Rawhide. 1.1.8 was published 2 days ago: https://github.com/conventional-changelog/conventional-changelog/commit/aee8b8ef50643b17cb4c79c00a0dd87a313cad8a

Either relax the deps or update npm(conventional-changelog-preset-loader)


Package otherwise approved.
Comment 6 Jared Smith 2018-03-29 17:04:08 UTC 
Repo requested at https://pagure.io/releng/fedora-scm-requests/issue/5526.
Comment 7 Jared Smith 2018-03-29 17:05:20 UTC 
For what it's worth, I built conventional-changelog-preset-loader version 1.1.8 earlier today.  https://koji.fedoraproject.org/koji/taskinfo?taskID=26042912
Comment 8 Jason Tibbitts 2018-03-30 22:18:27 UTC 
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/nodejs-conventional-recommended-bump
Comment 9 Jared Smith 2018-03-31 20:58:57 UTC 
Packaged in Rawhide, closing this issue
Note You need to log in before you can comment on or make changes to this bug.