Bug 1548764
Summary: | Review Request: googler - Google Search, Google Site Search, Google News from the terminal | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Robert-André Mauchin 🐧 <zebob.m> |
Component: | Package Review | Assignee: | Zbigniew Jędrzejewski-Szmek <zbyszek> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | package-review, zbyszek |
Target Milestone: | --- | Flags: | zbyszek:
fedora-review+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2018-03-29 16:19:52 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Robert-André Mauchin 🐧
2018-02-24 20:50:23 UTC
Looks all good, but I'm a bit wary about the phrasing of the Summary and %description. https://fedoraproject.org/wiki/Packaging:Guidelines#Trademarks_in_Summary_or_Description says that any chance of confusion that the package is the trademarked item, should be avoided. I think it'd be better to rephrase the summary as Summary: access google search, google site search, google news from the terminal %description: googler is a power tool to access Google (Web & News) websites and Google Site Search website from the command-line. [...] (I know the %description has a disclaimer at the end, let's be careful here.) Suggestion: %__make → make %{__install} → install (those macros are pointless) Done. Thanks for the review! Spec URL: https://raw.githubusercontent.com/eclipseo/packaging/d61747b/googler.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/jarun/fedora-rawhide-x86_64/00720764-googler/googler-3.5-1.fc28.src.rpm Spec diff: https://github.com/eclipseo/packaging/commit/d61747b68c58a7dc07d3ffc8b93e1364b04cad48#diff-99133c8d22409f773a2a56ffacf604d5 + package name is OK + latest version + license is acceptable for Fedora (GPLv3+) + license is specified correctly + builds and installs OK + P/R/BR look OK + fedora-review finds no issues + seems to work OK Package is APPROVED. (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/googler googler-3.5-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-187f8d5b15 googler-3.5-1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-961933f9c1 googler-3.5-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-187f8d5b15 googler-3.5-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. googler-3.5-1.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report. |