Spec URL: https://raw.githubusercontent.com/eclipseo/packaging/ec5f137/googler.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/jarun/fedora-rawhide-x86_64/00720656-googler/googler-3.5-1.fc28.src.rpm Description: googler is a power tool to Google (Web & News) and Google Site Search from the command-line. It shows the title, URL and abstract for each result, which can be directly opened in a browser from the terminal. Results are fetched in pages (with page navigation). Supports sequential searches in a single googler instance. googler was initially written to cater to headless servers without X. You can integrate it with a text-based browser. However, it has grown into a very handy and flexible utility that delivers much more. For example, fetch any number of results or start anywhere, limit search by any duration, define aliases to google search any number of websites, switch domains easily... all of this in a very clean interface without ads or stray URLs. The shell completion scripts make sure you don't need to remember any options. Fedora Account System Username: eclipseo
Looks all good, but I'm a bit wary about the phrasing of the Summary and %description. https://fedoraproject.org/wiki/Packaging:Guidelines#Trademarks_in_Summary_or_Description says that any chance of confusion that the package is the trademarked item, should be avoided. I think it'd be better to rephrase the summary as Summary: access google search, google site search, google news from the terminal %description: googler is a power tool to access Google (Web & News) websites and Google Site Search website from the command-line. [...] (I know the %description has a disclaimer at the end, let's be careful here.) Suggestion: %__make → make %{__install} → install (those macros are pointless)
Done. Thanks for the review! Spec URL: https://raw.githubusercontent.com/eclipseo/packaging/d61747b/googler.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/jarun/fedora-rawhide-x86_64/00720764-googler/googler-3.5-1.fc28.src.rpm Spec diff: https://github.com/eclipseo/packaging/commit/d61747b68c58a7dc07d3ffc8b93e1364b04cad48#diff-99133c8d22409f773a2a56ffacf604d5
+ package name is OK + latest version + license is acceptable for Fedora (GPLv3+) + license is specified correctly + builds and installs OK + P/R/BR look OK + fedora-review finds no issues + seems to work OK Package is APPROVED.
(fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/googler
googler-3.5-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-187f8d5b15
googler-3.5-1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-961933f9c1
googler-3.5-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-187f8d5b15
googler-3.5-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.
googler-3.5-1.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.