Bug 1550187
| Summary: | Upx needs patch to work with new version of lzma-sdk | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Tomáš Korbař <tomas.korb> | ||||||||
| Component: | upx | Assignee: | Gwyn Ciesla <gwync> | ||||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||
| Severity: | unspecified | Docs Contact: | |||||||||
| Priority: | unspecified | ||||||||||
| Version: | 29 | CC: | gwync, jskarvad | ||||||||
| Target Milestone: | --- | ||||||||||
| Target Release: | --- | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | upx-3.95-1.fc27 upx-3.95-1.fc28 | Doc Type: | If docs needed, set a value | ||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2018-09-06 02:31:32 UTC | Type: | Bug | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Attachments: |
|
||||||||||
In the future we could also look at the UPX_LZMA_VERSION and make sure that it is absolutely necesary to have it here. Please let me know when to commit and build this for rawhide. (In reply to Gwyn Ciesla from comment #2) > Please let me know when to commit and build this for rawhide. Sure, we will let you know. Tomas is working on another patch. https://bugzilla.redhat.com/show_bug.cgi?id=1546091 I've uploaded new patchs for lzmasdk spec and library. When these changes will be accepted we can unbundle lzma-sdk 4.43 from upx and get rid of UPX_LZMA_VERSION and UPX_LZMADIR. Created attachment 1403685 [details]
suggested patch for upx spec with unbundle lzma-sdk
Added patch for unbundle and removed UPX_LZMA_VERSION, UPX_LZMADIR.
I've also deleted file that was testing if bundled lzma-sdk is present and the folder with bundled lzma-sdk.
Created attachment 1403701 [details]
patch for source code and makefile
This patch will unbundle lzma-sdk from source code.
I added some necessary includes and for example renamed LzmaDecode function to LzmaLegacyDecode because this function is completely different in version 18.
I tested compilation, rpm package and compression with upx and everything worked fine so i think i have not left anywhere any bugs.
This bug appears to have been reported against 'rawhide' during the Fedora 29 development cycle. Changing version to '29'. upx-3.95-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-a8ddebe734 upx-3.95-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-0d8d15ff89 upx-3.95-1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-0d8d15ff89 upx-3.95-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-a8ddebe734 upx-3.95-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. upx-3.95-1.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report. |
Created attachment 1401999 [details] suggested patch for upx spec Description of problem: In specfile the lzma include directory is specified as lzma465 and version 0x465. For the new version the directory needs to be lzma-sdk and we can also change version to 0x181 Steps to Reproduce: 1. Check specfile 2. 3. Actual results: UPX_LZMA_VERSION=0x465 UPX_LZMADIR=%{_includedir}/lzma465 make %{?_smp_mflags} -C src Expected results: UPX_LZMA_VERSION=0x181 UPX_LZMADIR=%{_includedir}/lzma-sdk make %{?_smp_mflags} -C src Additional info: