Bug 1550187 - Upx needs patch to work with new version of lzma-sdk
Summary: Upx needs patch to work with new version of lzma-sdk
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: upx
Version: 29
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Gwyn Ciesla
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-02-28 18:04 UTC by Tomáš Korbař
Modified: 2018-09-06 03:09 UTC (History)
2 users (show)

Fixed In Version: upx-3.95-1.fc27 upx-3.95-1.fc28
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-09-06 02:31:32 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
suggested patch for upx spec (460 bytes, patch)
2018-02-28 18:04 UTC, Tomáš Korbař
no flags Details | Diff
suggested patch for upx spec with unbundle lzma-sdk (980 bytes, patch)
2018-03-04 08:29 UTC, Tomáš Korbař
no flags Details | Diff
patch for source code and makefile (5.43 KB, patch)
2018-03-04 09:15 UTC, Tomáš Korbař
no flags Details | Diff

Description Tomáš Korbař 2018-02-28 18:04:55 UTC
Created attachment 1401999 [details]
suggested patch for upx spec

Description of problem:
In specfile the lzma include directory is specified as lzma465 and version 0x465. For the new version the directory needs to be lzma-sdk and we can also change version to 0x181

Steps to Reproduce:
1. Check specfile
2.
3.

Actual results:
UPX_LZMA_VERSION=0x465 UPX_LZMADIR=%{_includedir}/lzma465 make %{?_smp_mflags} -C src

Expected results:
UPX_LZMA_VERSION=0x181 UPX_LZMADIR=%{_includedir}/lzma-sdk make %{?_smp_mflags} -C src

Additional info:

Comment 1 Tomáš Korbař 2018-02-28 18:10:14 UTC
In the future we could also look at the UPX_LZMA_VERSION and make sure that it is absolutely necesary to have it here.

Comment 2 Gwyn Ciesla 2018-02-28 18:36:16 UTC
Please let me know when to commit and build this for rawhide.

Comment 3 Jaroslav Škarvada 2018-03-02 10:24:26 UTC
(In reply to Gwyn Ciesla from comment #2)
> Please let me know when to commit and build this for rawhide.

Sure, we will let you know. Tomas is working on another patch.

Comment 4 Tomáš Korbař 2018-03-03 13:35:03 UTC
https://bugzilla.redhat.com/show_bug.cgi?id=1546091
I've uploaded new patchs for lzmasdk spec and library.
When these changes will be accepted we can unbundle lzma-sdk 4.43 from upx and get rid of UPX_LZMA_VERSION and UPX_LZMADIR.

Comment 5 Tomáš Korbař 2018-03-04 08:29:43 UTC
Created attachment 1403685 [details]
suggested patch for upx spec with unbundle lzma-sdk

Added patch for unbundle and removed UPX_LZMA_VERSION, UPX_LZMADIR.
I've also deleted file that was testing if bundled lzma-sdk is present and the folder with bundled lzma-sdk.

Comment 6 Tomáš Korbař 2018-03-04 09:15:48 UTC
Created attachment 1403701 [details]
patch for source code and makefile

This patch will unbundle lzma-sdk from source code.
I added some necessary includes and for example renamed LzmaDecode function to LzmaLegacyDecode because this function is completely different in version 18.
I tested compilation, rpm package and compression with upx and everything worked fine so i think i have not left anywhere any bugs.

Comment 7 Jan Kurik 2018-08-14 11:07:52 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 29 development cycle.
Changing version to '29'.

Comment 8 Fedora Update System 2018-08-27 16:45:13 UTC
upx-3.95-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-a8ddebe734

Comment 9 Fedora Update System 2018-08-27 16:45:23 UTC
upx-3.95-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-0d8d15ff89

Comment 10 Fedora Update System 2018-08-28 10:51:17 UTC
upx-3.95-1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-0d8d15ff89

Comment 11 Fedora Update System 2018-08-28 11:39:18 UTC
upx-3.95-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-a8ddebe734

Comment 12 Fedora Update System 2018-09-06 02:31:32 UTC
upx-3.95-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.

Comment 13 Fedora Update System 2018-09-06 03:09:57 UTC
upx-3.95-1.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.